From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26300 invoked by alias); 5 Dec 2018 23:09:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26286 invoked by uid 89); 5 Dec 2018 23:09:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=BAYES_00,BODY_8BITS,GARBLED_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail.aegee.org Received: from mail.aegee.org (HELO mail.aegee.org) (144.76.142.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Dec 2018 23:09:09 +0000 Authentication-Results: mail.aegee.org/wB5N8qRn018384; auth=pass (PLAIN) smtp.auth=didopalauzov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1544051334; i=dkim+MSA-tls@aegee.org; r=y; bh=8+8ZmUKFC2Hy2sEvwRzT6H1gfK4Ejy2dYEZbIBokKU4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=oMsOSnmIVL2qYmhybFA0GOEjePLe7DCAOJibUbRMd4vXjI9d+D2r/RRQJ+QTYLN4i OXgYwFhP+PfGxjSiy8xOVPrAN5fvEcbAOZLblj1ustK9pn6eF+WnnW1Tw8YdOMF+r6 kx+3mmOcgxuUdhLToGIyvi/t3d3FgObBn1U1ql/Xrh4iFXCwqICcNsjvLljkwkZm56 eklr19VQNakmNfTeQo7TWMlJ10D9EUG7sUg1OZPpLyotIKUNu4UoEaIkuo3C+ytB/i 0sguD/NnK/UxjqmCYxNskhGh5jPMHG0VbBHtlQtjHxA7cOzSduflzJYsGsvFLM5fWY e40jAuIgyRPtLrUIUQbdh3ZTDthpSg7vHvnEE2E1RmE+87Fw3J1WTZ+suycgMdYCHB WnvtdXzY1212Q0lD0lG2YrVayqbKEMQtw6gE8xTG4Y/J7YtUVwi3KDl3auI3IjROK1 Kq/WcZ2MgY96tgQEpWQFXtkgh+F17s+Mhc2nkGkb+CwsrCD33lqoTyAVWHCcwIsVI5 1lWEVXTVdXY865RpS7uOv+bQJYsuJ0j4c72ws94Wj5rSSfdMmmPUZRVlJLkszXLiSS ia8rWOiW7kJkWTOPjvwJ6v2FFf6E0Fv0lTdl4NG4WnGEWQAesVMU7Y54NX5gXu2sat J5oMl1GHNJfEybMF9B0TSfgw= Authentication-Results: mail.aegee.org/wB5N8qRn018384; dkim=none Received: from Tylan (37-219-194-104.nat.bb.dnainternet.fi [37.219.194.104]) (authenticated bits=0) by mail.aegee.org (8.15.2/8.15.2) with ESMTPSA id wB5N8qRn018384 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 5 Dec 2018 23:08:54 GMT Message-ID: <1295a9f1d810e3ad264b13c10ff6b94af4d02e35.camel@aegee.org> Subject: Re: Linking gdb with -ltinfow, if libtinfo is not available From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= To: Simon Marchi , Simon Marchi Cc: "gdb-patches@sourceware.org" Date: Wed, 05 Dec 2018 23:09:00 -0000 In-Reply-To: References: <30919bd86dea123f624ccd1f069aff432622fb6e.camel@aegee.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.31.3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00066.txt.bz2 Hello, my name is spelled correctly. A further test would to have libtermcap and no libtinfo.so on the -L explicit and implicit paths. Regards Дилян On Wed, 2018-12-05 at 19:59 +0000, Simon Marchi wrote: > On 2018-12-05 11:41 a.m., Дилян Палаузов wrote: > > Hello, > > > > you should be able to test this by having libtinfo.so in a directory, > > that is not introduced to the linker by -L and is not default for the > > compiller or linker and have libtinfow.so in а path passed by -L; > > possibly moving libtinfo.so to a location that is still considered by > > ldconfig. > > I tested this in a docker container, as to avoid messing up my system. I > deleted all traces of libtinfo.so, compiled and installed ncurses by hand with > > --with-termlib --with-shared --enable-widec --prefix=/usr > > which got me a libtinfow.so. I was then able to reproduce the linking > problem and confirm that your patch works (we just need to re-generate > configure). > > So here's what I propose pushing. My cyrillic is not totally on point, > does your name look good in the ChangeLog entry below? Or would you > prefer to have a romanized version in there? > > > From 70670e00263468aa36dce313d2241b5f953596af Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Wed, 5 Dec 2018 14:21:31 -0500 > Subject: [PATCH] Look for tgetent in libtinfow > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > On some systems where ncurses is only available in the "wide" version > (compiled with --with-widec), there might be no libtinfo.so, only a > libtinfow.so. Look for libtinfow in addition to libtinfo. > > gdb/ChangeLog: > > YYYY-MM-DD Simon Marchi > Дилян Палаузов > > PR gdb/23950 > * configure.ac: Search for tgetent in libtinfow. > * configure: Re-generate. > --- > gdb/configure | 2 +- > gdb/configure.ac | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/configure b/gdb/configure > index 7665ba65319..603c413fe8e 100755 > --- a/gdb/configure > +++ b/gdb/configure > @@ -9027,7 +9027,7 @@ return tgetent (); > return 0; > } > _ACEOF > -for ac_lib in '' termcap tinfo curses ncursesw ncurses; do > +for ac_lib in '' termcap tinfow tinfo curses ncursesw ncurses; do > if test -z "$ac_lib"; then > ac_res="none required" > else > diff --git a/gdb/configure.ac b/gdb/configure.ac > index e1ea60660b9..b40c53a06cd 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -592,7 +592,7 @@ case $host_os in > esac > > # These are the libraries checked by Readline. > -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) > +AC_SEARCH_LIBS(tgetent, [termcap tinfow tinfo curses ncursesw ncurses]) > > if test "$ac_cv_search_tgetent" = no; then > CONFIG_OBS="$CONFIG_OBS stub-termcap.o" > -- > 2.19.2 >