From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25890 invoked by alias); 13 Jan 2011 13:45:12 -0000 Received: (qmail 25865 invoked by uid 22791); 13 Jan 2011 13:45:10 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,TW_GD X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Thu, 13 Jan 2011 13:45:04 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 13 Jan 2011 13:44:59 +0000 Received: from [10.1.77.49] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 13 Jan 2011 13:44:57 +0000 Subject: Re: PING: [patch, testsuite] General ARM target triplet From: Matthew Gretton-Dann To: Yao Qi Cc: Pedro Alves , gdb-patches@sourceware.org, Andreas Schwab , Richard Earnshaw , "Joseph S. Myers" In-Reply-To: <4D25CD5E.4030204@codesourcery.com> References: <4CF91BD4.7090708@codesourcery.com> <201012131407.08185.pedro@codesourcery.com> <4D063BA8.4000404@codesourcery.com> <201012131539.22392.pedro@codesourcery.com> <4D25CD5E.4030204@codesourcery.com> Date: Thu, 13 Jan 2011 14:53:00 -0000 Message-ID: <1294926291.9907.90.camel@e102319-lin.cambridge.arm.com> Mime-Version: 1.0 X-MC-Unique: 111011313445903901 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00294.txt.bz2 On Thu, 2011-01-06 at 22:10 +0800, Yao Qi wrote: > On 12/13/2010 11:39 PM, Pedro Alves wrote: > >> > OK, I combine them together in one single patch this time. > > Thanks. If/when everyone's happy with the triplet bits > > proper, this is okay. >=20 > Ping. Are you happy with this triplet? :-) >=20 > http://sourceware.org/ml/gdb-patches/2010-12/msg00187.html >=20 Looks okay to me apart from the following: > --- a/gdb/testsuite/gdb.asm/asm-source.exp > +++ b/gdb/testsuite/gdb.asm/asm-source.exp > @@ -40,10 +40,7 @@ switch -glob -- [istarget] { > set asm-flags "-no-mdebug -I${srcdir}/${subdir} -I${objdir}/${su= bdir}" > set debug-flags "-gdwarf-2" > } > - "*arm-*-*" { > - set asm-arch arm > - } > - "xscale-*-*" { > + "*arm*-*-*" { Shouldn't the test read "arm*-*-*" (following on from Richard's and Joseph'= s comments? Note that I am not a maintainer and so this is not an approval. Thanks, Matt --=20 Matthew Gretton-Dann Principal Engineer - PDSW Tools ARM Ltd