From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22116 invoked by alias); 31 Dec 2010 18:15:52 -0000 Received: (qmail 22106 invoked by uid 22791); 31 Dec 2010 18:15:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 31 Dec 2010 18:15:47 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 81DA91B401B; Fri, 31 Dec 2010 18:15:44 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Cc: toolchain-devel@blackfin.uclinux.org Subject: [PATCH] sim: enable hw_tree_delete in sim_hw_uninstall Date: Fri, 31 Dec 2010 22:25:00 -0000 Message-Id: <1293819313-29542-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00570.txt.bz2 I can't find any history for why the call to hw_tree_delete is commented out, and the VCS history shows that this goes back to the original import in 2009. I did find some vague reference to it from 2000 (pretty close to the original import of code), but no actual details. Without this call, every new instance of the sim results in all old previously allocated resources being leaked. With some devices, this isn't just memory, it's things like open file descriptors or mmaps. So if there are pending issues with this, I'd rather we get the sims sorted out rather than continuing to leak this stuff. Especially since the "let's wait for the sims to fix themselves" hasn't actually happened in the last 10+ years. Signed-off-by: Mike Frysinger 2010-12-31 Mike Frysinger * sim-hw.c (sim_hw_uninstall): Uncomment hw_tree_delete. --- sim/common/sim-hw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c index e946f67..9f37145 100644 --- a/sim/common/sim-hw.c +++ b/sim/common/sim-hw.c @@ -318,7 +318,7 @@ sim_hw_init (struct sim_state *sd) static void sim_hw_uninstall (struct sim_state *sd) { - /* hw_tree_delete (STATE_HW (sd)->tree); */ + hw_tree_delete (STATE_HW (sd)->tree); free (STATE_HW (sd)); STATE_HW (sd) = NULL; } -- 1.7.3.1