From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30719 invoked by alias); 28 Dec 2010 14:34:01 -0000 Received: (qmail 30708 invoked by uid 22791); 28 Dec 2010 14:34:00 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Dec 2010 14:33:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 413BB2BABF6; Tue, 28 Dec 2010 09:33:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rxGOSVHR82kW; Tue, 28 Dec 2010 09:33:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C15752BABF2; Tue, 28 Dec 2010 09:33:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1F0FA145870; Tue, 28 Dec 2010 18:33:44 +0400 (RET) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Joel Brobecker Subject: [RFA/commit] Add documentation for TARGET_OBJECT_OSDATA Date: Tue, 28 Dec 2010 15:29:00 -0000 Message-Id: <1293546820-2891-1-git-send-email-brobecker@adacore.com> In-Reply-To: <201012281104.06493.pedro@codesourcery.com> References: <201012281104.06493.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00510.txt.bz2 > BZZT. Don't do that. The return of a TARGET_OBJECT_OSDATA request > should be a table that follows the gdb/features/osdata.dtd dtd. It > is meant as data to be fed into the "info os" command (and a non-submitted > -info-os MI command). I propose to expand the comment besides TARGET_OBJECT_OSDATA to make it clear... gdb/ChangeLog: * target.h (enum target_object): Expand the documentation of TARGET_OBJECT_OSDATA a bit. Looks good? Thanks, -- Joel --- gdb/target.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gdb/target.h b/gdb/target.h index ea27b2c..6a1ec92 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -256,7 +256,8 @@ enum target_object /* Currently loaded libraries, in XML format. */ TARGET_OBJECT_LIBRARIES, /* Get OS specific data. The ANNEX specifies the type (running - processes, etc.). */ + processes, etc.). The data being transfered is expected to follow + the DTD specified in features/osdata.dtd. */ TARGET_OBJECT_OSDATA, /* Extra signal info. Usually the contents of `siginfo_t' on unix platforms. */ -- 1.7.1