Re: [patch 1/3] Implement support for PowerPC BookE masked watchpoints

Thiago Jung Bauermann
2010-11-27T13:29:35Z

On Fri, 2010-11-26 at 12:58 +0200, Eli Zaretskii wrote:
> > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
> > Date: Tue, 23 Nov 2010 19:42:24 -0200
> >
> > I broke up the patch I submitted previously as "[patch 2/2] Implement
> > support for PowerPC BookE masked and ranged watchpoints" into the three
> > patches in this series. The first adds masked watchpoint support, the
> > second adds ranged watchpoints support (without the watch-range command)
> > and the third adds the polemic watch-range command.
> >
> > This patch is a bigger than the others because it has to add code to
> > handle the new target methods extra_resources_needed,
> > works_in_software_mode and print_one_detail. The code is the same as
> > what was already reviewed though, except for fixing the GNU style
> > regarding whitespace in ppc_linux_{insert,remove}_mask_watchpoint.
> >
> > I changed a bit the wording of the paragraph mentioning masked
> > watchpoint support in the NEWS file, and also added a "Changed Commands"
> > section so the NEWS entry needs another review. The manual part is the
> > same except for omitting the sentences about ranged watchpoint support.
> >
> > Ok to commit?
>
> Correct me if I'm wrong, but since I already reviewed and approved the
> documentation changes in this patch (and other parts thereof), there's
> no need for me to review it again in parts, right?

I just wanted to make sure that you're happy with the wording in this
paragraph:

+* When locally debugging programs on PowerPC BookE processors running
+ a Linux kernel version 2.6.34 or later GDB supports masked hardware
+ watchpoints, which specifiy a mask in addition to an address to watch.
+ The mask specifies that some bits of an address (the bits which are
+ reset in the mask) should be ignored when matching the address accessed
+ by the inferior against the watchpoint address. See the "PowerPC Embedded"
+ section in the user manual for more details.

and also with the new "Changed commands" section that I added. The
changes in the manual are the same and don't need review.