Re: [patch 1/3] Implement support for PowerPC BookE masked watchpoints

Eli Zaretskii
2010-11-26T10:57:08Z

> From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 23 Nov 2010 19:42:24 -0200
>
> I broke up the patch I submitted previously as "[patch 2/2] Implement
> support for PowerPC BookE masked and ranged watchpoints" into the three
> patches in this series. The first adds masked watchpoint support, the
> second adds ranged watchpoints support (without the watch-range command)
> and the third adds the polemic watch-range command.
>
> This patch is a bigger than the others because it has to add code to
> handle the new target methods extra_resources_needed,
> works_in_software_mode and print_one_detail. The code is the same as
> what was already reviewed though, except for fixing the GNU style
> regarding whitespace in ppc_linux_{insert,remove}_mask_watchpoint.
>
> I changed a bit the wording of the paragraph mentioning masked
> watchpoint support in the NEWS file, and also added a "Changed Commands"
> section so the NEWS entry needs another review. The manual part is the
> same except for omitting the sentences about ranged watchpoint support.
>
> Ok to commit?

Correct me if I'm wrong, but since I already reviewed and approved the
documentation changes in this patch (and other parts thereof), there's
no need for me to review it again in parts, right?