Re: [PATCH v2] gdbserver: bfin: new port

Mike Frysinger
2010-12-13T19:24:08Z

[-- Attachment #1: Type: Text/Plain, Size: 1395 bytes --]

On Monday, December 13, 2010 13:43:59 Pedro Alves wrote:
> > +++ b/gdb/regformats/reg-bfin.dat
> > +32:text_addr
> > +32:text_end_addr
> > +32:data_addr
> > +32:fdpic_exec
> > +32:fdpic_interp
> > +32:ipend
>
> Hmmm. These last 6 look to be some kind of pseudo registers, not
> part of the ISA -- I'm quite surprised to see these here, as
> part of the bfin core register set. I understand these to be
> fdpic related; ISTR some discussion about making these be reported
> with a new qXfer object? That'd be better, IMO.
>
> I haven't looked at any bfin docs, but if any of the other
> registers aren't core registers (only available in some variants), you
> should consider implementing xml target register descriptions.

correct, these last 6 are the only pseudo regs from the ISA perspective. the
rest are actual hardware registers (well, the PC/CC registers are a little
special, but i dont think that's relevant to this discussion).

i vaguely recall people voicing displeasure at the FDPIC implementation
details in the past, but i'm not sure this is something that we can "recover"
from. Linux declares these things are registers via the ptrace ABI and
gdbserver is merely forwarding that along.

also, the Blackfin port isnt doing anything new here. we copied the decisions
made by the FRV peeps and accepted into the gdb tree already.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]