Re: [PATCH v2] gdbserver: bfin: new port

Pedro Alves
2010-12-14T18:06:56Z

On Tuesday 14 December 2010 17:47:11, Mike Frysinger wrote:
> > I think that's the best approach. Would it be easy to split
> > the linux bits out of gdb/bfin-tdep.c into gdb/bfin-linux-tdep.c?
> > You could even push the bare metal (bfin-elf?) bits first without
> > any linux bits as a first step.
>
> i imagine for someone who is a gdb expert, this would be trivial. but it
> would require a bit of research on my side, so i'd prefer to not do this
> initially. the code Joel is OK with supports both Blackfin bare metal and
> Blackfin Linux/FLAT.

Okay.

>
> i'll open a tracker item to get this stuff eventually split out, but i dont
> see it being done in a time frame that is before the gdb-7.3 release which i
> really want to be a part of.

That's months away. I think you're over estimating. :-)

>
> > Please also get rid of gdb/config/bfin/bfin.mt -- .mt files have
> > long since been eliminated from gdb, the code that would go there you
> > already have in configure.tgt.
>
> i couldnt find documentation on this file (or mts in general) so i was
> hesitant to touch it. the only thing we have in there is to set the TDEPFILES
> variable, but i guess that too is no longer used anywhere ?

Correct. Those sets of TDEPFILES in .mt files got migrated to
configure.tgt where you now set gdb_target_obs (as you already have, your
.mt file in the patch is empty). BTW, you should also include
linux-tdep.o in gdb_target_obs, and call linux_init_abi somewhere
in your GDB_OSABI_LINUX osabi handler.

--
Pedro Alves