Re: [PATCH v2] gdb: bfin: new port

Joel Brobecker
2010-12-14T06:03:07Z

> 2010-11-16 Jie Zhang <jie.zhang@analog.com>
>
> * Makefile.in (ALLDEPFILES): Add bfin-tdep.c.
> (HFILES_NO_SRCDIR): Add bfin-tdep.h.

(ALL_TARGET_OBS): Add bfin-tdep.o

> * NEWS: Mention new Blackfin port.
> * bfin-tdep.c, bfin-tdep.h, config/bfin/bfin.mt: New files.
> * configure.tgt (bfin-*-*): Handle bfin targets.

The syscall file is also missing.

There are a couple of nits, highlighted below. But the patch is
pre-approved with those nits fixed as suggested. One little issue,
though: Please make sure that Eli reviews the change in the NEWS
file before checking in that part of the patch (it can be done
separately).

> +#ifdef _DEBUG
> + fprintf (stderr, "frameless pc case base %x\n", cache->base);
> +#endif

You forgot to remove the #ifdef DEBUG block...

> +/* Return the Blackfin ABI associated with GDBARCH. */
> +static inline enum bfin_abi
> +bfin_abi (struct gdbarch *gdbarch)
> +{
> + return gdbarch_tdep (gdbarch)->bfin_abi;
> +}

Please define that function in bfin-tdep.c, and put a declaration in
bfin-tdep.h instead.

--
Joel