From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76777-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1249 invoked by alias); 3 Dec 2010 17:36:06 -0000
Received: (qmail 1202 invoked by uid 22791); 3 Dec 2010 17:36:04 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25)    by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 03 Dec 2010 17:35:59 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21])	by service87.mimecast.com;	Fri, 03 Dec 2010 17:35:55 +0000
Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0);	 Fri, 3 Dec 2010 17:35:53 +0000
Subject: Re: [patch, testsuite] General ARM target triplet
From: Richard Earnshaw <rearnsha@arm.com>
To: Yao Qi <yao@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
In-Reply-To: <4CF91BD4.7090708@codesourcery.com>
References: <4CF91BD4.7090708@codesourcery.com>
Date: Fri, 03 Dec 2010 17:36:00 -0000
Message-Id: <1291397752.27205.18.camel@e102346-lin.cambridge.arm.com>
Mime-Version: 1.0
X-MC-Unique: 110120317355501401
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00022.txt.bz2


On Sat, 2010-12-04 at 00:33 +0800, Yao Qi wrote:
> diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> index f37b2f3..64e56ea 100644
> --- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> +++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> @@ -27,7 +27,7 @@ set core-regs ""
>  set regdir ""
>  set architecture ""
>  switch -glob -- [istarget] {
> -    "*arm-*-*" {
> +    "*arm*-*-*" {
>          set core-regs {arm-core.xml}
>      }
>      "xscale-*-*" {

So I think this is too broad.  arm in the middle of a string could match
many things that are not ARM cores at all.  I think the original code
dates back to support for StrongARM and someone was being lazy.

It's probably better to make this a specific test for strongarm* and
arm* rather than a very wide-ranging glob.

R.