From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23902 invoked by alias); 27 Nov 2010 13:29:35 -0000 Received: (qmail 23892 invoked by uid 22791); 27 Nov 2010 13:29:34 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 27 Nov 2010 13:29:29 +0000 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by e24smtp03.br.ibm.com (8.14.4/8.13.1) with ESMTP id oARDKh9x013463 for ; Sat, 27 Nov 2010 11:20:43 -0200 Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oARDS8cZ2318530 for ; Sat, 27 Nov 2010 10:28:08 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oARDTPVa019783 for ; Sat, 27 Nov 2010 11:29:25 -0200 Received: from [9.18.199.242] ([9.18.199.242]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oARDTPmx019780; Sat, 27 Nov 2010 11:29:25 -0200 Subject: Re: [patch 1/3] Implement support for PowerPC BookE masked watchpoints From: Thiago Jung Bauermann To: Eli Zaretskii Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, brobecker@adacore.com In-Reply-To: <83oc9c73me.fsf@gnu.org> References: <1290548544.3164.37.camel@hactar> <83oc9c73me.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Date: Sat, 27 Nov 2010 13:29:00 -0000 Message-ID: <1290864564.3009.45.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00464.txt.bz2 On Fri, 2010-11-26 at 12:58 +0200, Eli Zaretskii wrote: > > From: Thiago Jung Bauermann > > Cc: Jan Kratochvil , Joel Brobecker , Eli Zaretskii > > Date: Tue, 23 Nov 2010 19:42:24 -0200 > > > > I broke up the patch I submitted previously as "[patch 2/2] Implement > > support for PowerPC BookE masked and ranged watchpoints" into the three > > patches in this series. The first adds masked watchpoint support, the > > second adds ranged watchpoints support (without the watch-range command) > > and the third adds the polemic watch-range command. > > > > This patch is a bigger than the others because it has to add code to > > handle the new target methods extra_resources_needed, > > works_in_software_mode and print_one_detail. The code is the same as > > what was already reviewed though, except for fixing the GNU style > > regarding whitespace in ppc_linux_{insert,remove}_mask_watchpoint. > > > > I changed a bit the wording of the paragraph mentioning masked > > watchpoint support in the NEWS file, and also added a "Changed Commands" > > section so the NEWS entry needs another review. The manual part is the > > same except for omitting the sentences about ranged watchpoint support. > > > > Ok to commit? > > Correct me if I'm wrong, but since I already reviewed and approved the > documentation changes in this patch (and other parts thereof), there's > no need for me to review it again in parts, right? I just wanted to make sure that you're happy with the wording in this paragraph: +* When locally debugging programs on PowerPC BookE processors running + a Linux kernel version 2.6.34 or later GDB supports masked hardware + watchpoints, which specifiy a mask in addition to an address to watch. + The mask specifies that some bits of an address (the bits which are + reset in the mask) should be ignored when matching the address accessed + by the inferior against the watchpoint address. See the "PowerPC Embedded" + section in the user manual for more details. and also with the new "Changed commands" section that I added. The changes in the manual are the same and don't need review. -- []'s Thiago Jung Bauermann IBM Linux Technology Center