From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6383 invoked by alias); 23 Nov 2010 22:05:04 -0000 Received: (qmail 6374 invoked by uid 22791); 23 Nov 2010 22:05:03 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 22:04:49 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp03.br.ibm.com (8.14.4/8.13.1) with ESMTP id oANLuGIL027855 for ; Tue, 23 Nov 2010 19:56:16 -0200 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oANMBhtx2932874 for ; Tue, 23 Nov 2010 20:11:43 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oANM4XPi010136 for ; Tue, 23 Nov 2010 20:04:33 -0200 Received: from [9.8.10.218] ([9.8.10.218]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oANM4W6o010125; Tue, 23 Nov 2010 20:04:33 -0200 Subject: Re: [patch 2/2] Implement support for PowerPC BookE masked and ranged watchpoints From: Thiago Jung Bauermann To: Joel Brobecker Cc: Jan Kratochvil , Eli Zaretskii , gdb-patches@sourceware.org In-Reply-To: <20101120045951.GN2634@adacore.com> References: <1282074110.2606.703.camel@hactar> <1287807761.10521.423.camel@hactar> <838w1p8egs.fsf@gnu.org> <1288403952.2598.58.camel@hactar> <83wrp05f2f.fsf@gnu.org> <1288648026.3377.7.camel@hactar> <83d3qo5qkj.fsf@gnu.org> <1288905125.14606.4.camel@hactar> <20101116040116.GA19243@host0.dyn.jankratochvil.net> <1290196508.5540.101.camel@hactar> <20101120045951.GN2634@adacore.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 23 Nov 2010 22:05:00 -0000 Message-ID: <1290549884.3164.54.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00377.txt.bz2 On Fri, 2010-11-19 at 20:59 -0800, Joel Brobecker wrote: > > Changed to: > > > > +The watchpoint will stop execution of the inferior whenever it\n\ > > +writes to any address within the [start-address, end-address] range\n\ > > +(including start-address and end-address).")); > > Can you move the "writes" to the line before? This is to prevent > breaking line between the subject and the verb, making it easier > for the user to read... Ok. Fixed in the patch I just posted. > > Previous patches in this series also used this style and were accepted, > > so there's currently code like that in ppc-linux-nat.c in CVS HEAD > > (e.g., ppc_linux_{insert,remove}_hw_breakpoint, > > ppc_linux_{insert,remove}_watchpoint). Should I keep this patch like > > this for consistency, or change this patch and the existing instances? > > You'll have to excuse us, because not all of us are aware of the entire > coding standard used in GDB. It makes me want to revive the idea of > a Wiki page, because I need some kind of table/list to remind me of > all of them. If it's against the CS, then I'd just fix the instances > there, and let anyone changing the code on the other instances worry > about that (or you can do that already as an (obvious) separate patch). No problem. I fixed the whitespace in my patch. I'll commit a separate obvious patch later then. -- []'s Thiago Jung Bauermann IBM Linux Technology Center