From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [RFA] ignore PYTHONHOME environment variable.
Date: Tue, 23 Nov 2010 01:03:00 -0000 [thread overview]
Message-ID: <1290474202-885-1-git-send-email-brobecker@adacore.com> (raw)
This is something I hinted during one of our discussion at this year's
GCC Summit.
If PYTHONHOME is defined in the environment, then Py_SetProgramName
does not use the program-name location to find the python library.
Instead, it follows the PYTHONHOME, which can cause problems if
it points to a different Python installation, particularly if that
installation is from a different version of Python.
gdb/ChangeLog:
* python/python.c (_initialize_python): Call Py_SetPythonHome
if GDB was configured with --with-python.
Tested on x86_64-linux. Ok to commit?
---
gdb/python/python.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/gdb/python/python.c b/gdb/python/python.c
index d009be9..4f6f679 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -955,6 +955,12 @@ Enables or disables printing of Python stack traces."),
Py_Initialize ();
PyEval_InitThreads ();
+#ifdef WITH_PYTHON_PATH
+ /* We override any value that the PYTHONHOME might have, as we want
+ to make sure that we use the Python library that comes with GDB. */
+ Py_SetPythonHome (ldirname (python_libdir));
+#endif
+
gdb_module = Py_InitModule ("gdb", GdbMethods);
/* The casts to (char*) are for python 2.4. */
--
1.7.1
next reply other threads:[~2010-11-23 1:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 1:03 Joel Brobecker [this message]
2010-11-23 3:01 ` Jan Kratochvil
2010-11-23 9:29 ` Doug Evans
2010-11-23 16:31 ` Jan Kratochvil
2010-11-23 16:57 ` Doug Evans
2010-11-23 17:31 ` Joel Brobecker
2010-12-14 7:12 ` Joel Brobecker
2010-12-14 9:27 ` Jan Kratochvil
2010-12-14 10:33 ` Joel Brobecker
2011-01-13 22:57 ` Joel Brobecker
2011-01-15 9:17 ` Doug Evans
2011-01-15 11:26 ` Jan Kratochvil
2011-01-17 10:36 ` Joel Brobecker
2012-05-18 19:34 ` Jan Kratochvil
2012-05-28 14:41 ` Joel Brobecker
2012-05-28 17:30 ` Jan Kratochvil
2012-05-29 14:54 ` Joel Brobecker
2012-05-29 15:57 ` Jan Kratochvil
2012-05-30 14:37 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290474202-885-1-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox