From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76476-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16423 invoked by alias); 18 Nov 2010 13:56:42 -0000
Received: (qmail 16415 invoked by uid 22791); 18 Nov 2010 13:56:41 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 13:56:37 +0000
Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62])	by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id oAIDojF9006019;	Thu, 18 Nov 2010 13:50:45 GMT
Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0);	 Thu, 18 Nov 2010 13:56:29 +0000
Subject: Re: [RFA] About arm-tdep.c arm_in_function_epilogue_p function
From: Richard Earnshaw <rearnsha@arm.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: "'Daniel Jacobowitz'" <dan@codesourcery.com>,   "'Ulrich Weigand'" <uweigand@de.ibm.com>, gdb-patches@sourceware.org
In-Reply-To: <002101cb8726$8bbedec0$a33c9c40$@muller@ics-cnrs.unistra.fr>
References: <002701cb83f6$30b394e0$921abea0$@muller@ics-cnrs.unistra.fr>	 <20101116000346.GN8573@caradoc.them.org>	 <000a01cb8710$bcda4a00$368ede00$@muller@ics-cnrs.unistra.fr>	 <1290086858.18751.21.camel@e102346-lin.cambridge.arm.com>	 <002101cb8726$8bbedec0$a33c9c40$@muller@ics-cnrs.unistra.fr>
Content-Type: text/plain
Date: Thu, 18 Nov 2010 13:56:00 -0000
Message-Id: <1290088588.7919.1.camel@e102346-lin.cambridge.arm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00233.txt.bz2


On Thu, 2010-11-18 at 14:43 +0100, Pierre Muller wrote:
> OK, here is the patch.
> 
>   As already said, this patch doesn't change anything on
> the testsuite results for a armv7l linux machine.
> 
> > Why don't you just post a patch?  Then we can assess it as we would all
> > other patches.  The comments in the code at this point clearly don't
> > match the code, so something certainly needs fixing.
> > 
> > R.
> 

Looking at a wider context I think I see what's happened.  The block
here is essentially a copy of the block earlier in the function with
s/pc/sp/ applied.  Except this one variable wasn't updated properly.

OK.  

R

> OK to apply?
> 
> 2010-11-18  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * arm-tdep.c (arm_in_function_epilogue_p): Fix code when "MOV SP"
>         instruction is found.
> 
> Index: src/gdb/arm-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> retrieving revision 1.312
> diff -u -p -r1.312 arm-tdep.c
> --- src/14 Nov 2010 12:10:59 -0000      1.312
> +++ src/gdb/arm-tdep.c  18 Nov 2010 13:35:41 -0000
> @@ -2245,7 +2245,7 @@ arm_in_function_epilogue_p (struct gdbar
>         found_stack_adjust = 1;
>        else if ((insn & 0x0ffffff0) == 0x01a0d000)
>         /* MOV SP.  */
> -       found_return = 1;
> +       found_stack_adjust = 1;
>        else if ((insn & 0x0fff0000) == 0x08bd0000)
>         /* POP (LDMIA).  */
>         found_stack_adjust = 1;
>