From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93220 invoked by alias); 3 Feb 2018 04:59:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93211 invoked by uid 89); 3 Feb 2018 04:59:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Feb 2018 04:59:15 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w134x9E3014865 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 2 Feb 2018 23:59:13 -0500 Received: by simark.ca (Postfix, from userid 112) id 0DB7A1E757; Fri, 2 Feb 2018 23:59:09 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id F12E21E093; Fri, 2 Feb 2018 23:59:07 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 03 Feb 2018 04:59:00 -0000 From: Simon Marchi To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Remove use of dejagnu cleanup proc In-Reply-To: <20180202125638.7365-1-andrew.burgess@embecosm.com> References: <20180202125638.7365-1-andrew.burgess@embecosm.com> Message-ID: <128bdd85091849dc53eea059b13fabce@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 3 Feb 2018 04:59:09 +0000 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00046.txt.bz2 On 2018-02-02 07:56, Andrew Burgess wrote: > The 'cleanup' proc has been removed from dejagnu (Feb 15 2016). The > proc has not done anything useful since at least 2001 so removing > these calls should be harmless. > > gdb/testsuite/ChangeLog: > > * config/sid.exp (gdb_target_sid): Remove use of cleanup. > * config/sim.exp (gdb_target_sim): Remove use of cleanup. > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/config/sid.exp | 2 -- > gdb/testsuite/config/sim.exp | 1 - > 3 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/config/sid.exp > b/gdb/testsuite/config/sid.exp > index 36bd8611966..8ff0263b618 100644 > --- a/gdb/testsuite/config/sid.exp > +++ b/gdb/testsuite/config/sid.exp > @@ -146,7 +146,6 @@ proc gdb_target_sid { } { > gdb_expect { > -re ".*\[Ee\]rror.*$gdb_prompt $" { > perror "Couldn't set target for remote simulator." > - cleanup > gdb_exit > } > -re "Remote debugging using.*$gdb_prompt" { > @@ -154,7 +153,6 @@ proc gdb_target_sid { } { > } > timeout { > perror "Couldn't set target for remote simulator." > - cleanup > gdb_exit > } > } > diff --git a/gdb/testsuite/config/sim.exp > b/gdb/testsuite/config/sim.exp > index 7170a259837..d9072febc6a 100644 > --- a/gdb/testsuite/config/sim.exp > +++ b/gdb/testsuite/config/sim.exp > @@ -34,7 +34,6 @@ proc gdb_target_sim { } { > } > timeout { > perror "Couldn't set target for simulator." > - cleanup > return -1 > } > } LGTM. I guess with a recent Dejagnu it would produce an error to try to run it then? Simon