Re: [PATCH] call cp_lookup_symbol_namespace recursively to search symbols in C++ base classes

Yao Qi
2010-11-07T10:04:07Z

On 11/04/2010 04:52 PM, Liu, Lei wrote:
>
> I updated my patch to deal with this as long as the suggestions from
> Tom and Yao.
>
> I think in cp_set_block_scope, we should set scope name on a block
> regardless of whether processing_has_namespace_info has been set.
> For the cases that we only have classes but no namespaces, we still
> need scope information to tell us which symbols are valid in a block.
>
> How about this?

Lei,
It looks like your mail client eats spaces and tabs when you paste your
patch in your mail client. Please re-submit your patch again with
following steps,

1. Run 'git diff' to generate patch and dump it to a file, named
"foo.patch" for example,
2. Add your ChangeLog entry either in patch header or replied mail.
3. Reply mail in this thread, and *attach* your patch in your mail, and
send it out.

> + /* Just set the scope name if we get a valid one. */

Should be two spaces between "." and "*/". Please have a look at
"16.1.3 Comments" in
http://sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html#Coding-Standards

--
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739