From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5379 invoked by alias); 26 Oct 2010 15:36:17 -0000 Received: (qmail 5248 invoked by uid 22791); 26 Oct 2010 15:36:16 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_SUB_6CONS_WORD,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Oct 2010 15:36:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3EB9F2BAC86; Tue, 26 Oct 2010 11:36:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id X3-RRFEY+KD3; Tue, 26 Oct 2010 11:36:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1EEE12BAC7D; Tue, 26 Oct 2010 11:36:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 51B4FF59A2; Tue, 26 Oct 2010 11:36:10 -0400 (EDT) From: Joel Brobecker To: gdb-patches@sourceware.org Cc: Joel Brobecker Subject: [RFA/commit] replace strcmp by FILENAME_CMP for filename comparison Date: Tue, 26 Oct 2010 15:36:00 -0000 Message-Id: <1288107368-31496-1-git-send-email-brobecker@adacore.com> In-Reply-To: <20101026133928.GB2847@adacore.com> References: <20101026133928.GB2847@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00369.txt.bz2 This is a change that I suggested in a (very late) comment: http://www.sourceware.org/ml/gdb-patches/2010-08/msg00427.html http://www.sourceware.org/ml/gdb-patches/2010-10/msg00363.html gdb/ChangeLog: * dwarf2read.c (psymtab_include_file_name): Replace call to strcmp by call to FILENAME_CMP. Tested on x86_64-linux. Does it look OK? Thanks, -- Joel --- gdb/dwarf2read.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 7c78454..e613d90 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -10087,7 +10087,7 @@ psymtab_include_file_name (const struct line_header *lh, int file_index, pst_filename = copied_name; } - file_is_pst = strcmp (include_name_to_compare, pst_filename) == 0; + file_is_pst = FILENAME_CMP (include_name_to_compare, pst_filename) == 0; if (include_name_to_compare != include_name) xfree (include_name_to_compare); -- 1.7.1