Re: [patch 1/2] Convert hardware watchpoints to use breakpoint_ops

Joel Brobecker
2010-11-18T17:18:43Z

> I kept the wording as similar as possible to the original. Your
> suggestion is then to have the code below instead?
>
> + if (val == 1)
> + warning (_("\
> +Error inserting catchpoint %d: Your system does not support this type of catchpoint."),
> + bpt->owner->number);
> + else
> + warning (_("Error inserting catchpoint %d."), bpt->owner->number);

Yep!

> What about these additional comments (I'll send the updated patch after
> understanding your suggestion above)?

They look good to me. IMO, you can even drop the first hunk,
documenting the return value inside the target_ops vector definition.
I'd rather have no documentation than an incomplete duplicate of
the actual documentation located elsewhere. The idea is that, if
there is no documentation, then it might help trigger a search of
that documentation elsewhere. If there is some, then we might not
have the idea to look elsewhere for the rest...

--
Joel