Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [RFC] python: gdb.Type: strip typedefs past pointers too
Date: Sun, 19 Sep 2010 17:56:00 -0000	[thread overview]
Message-ID: <1284841648.1857.12.camel@localhost.localdomain> (raw)
In-Reply-To: <20100918141253.GM3845@adacore.com>

On Sat, 2010-09-18 at 10:12 -0400, Joel Brobecker wrote:
> Personally, I think that the current behavior is correct.  But I did
> not participate in the design of the API, so others will probably
> have a more informed opinion.
> 
> If we want to support the behavior you are looking for, I think it
> should be done either through the control of a parameter (defaulted
> to current behavior), or another method (recursive_strip_typedef).

The documentation reads:
>   -- Method on Type: strip_typedefs
>       Return a new `gdb.Type' that represents the real type, after
>       removing all layers of typedefs.

I feel that both the name of this function (which uses typedefs in
plural) and the documentation imply the behavior my patch tries to
achieve.

> Small nit on the coding style: the `||' should be at the beginning
> of the next line:

This nit (and the later one) I'll try to remember.

> (how about references?)

I have no idea. References are C++ things, aren't they?


Paul Bolle


  reply	other threads:[~2010-09-18 20:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-18 14:12 Paul Bolle
2010-09-19 16:35 ` Joel Brobecker
2010-09-19 17:56   ` Paul Bolle [this message]
2010-09-20  9:32     ` Daniel Jacobowitz
2010-09-20  9:48       ` Paul Bolle
2010-09-20 10:04         ` Daniel Jacobowitz
2010-09-20 10:15 ` Phil Muldoon
2010-09-20 10:53   ` Paul Bolle
2010-09-20 12:02 ` Jan Kratochvil
2010-09-20 16:25   ` Paul Bolle
2010-09-20 13:59     ` Paul Bolle
2010-09-20 16:08     ` Paul Bolle
2010-09-21 12:39     ` Jan Kratochvil
2010-09-20 13:14 ` André Pönitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284841648.1857.12.camel@localhost.localdomain \
    --to=pebolle@tiscali.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox