From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gZDwMOMLl2pLdhsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 13:31:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=fAKz3iTt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C3CC21E166; Tue, 01 Sep 2026 13:31:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E8C201E033 for ; Tue, 01 Sep 2026 13:31:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 777CE4BA2E35 for ; Tue, 1 Sep 2026 17:31:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 777CE4BA2E35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=fAKz3iTt Received: from sonic.asd.mail.yahoo.com (sonic-euwe4-0022.asd.mail.yahoo.com [34.2.86.21]) by sourceware.org (Postfix) with ESMTPS id 225D44BA2E27 for ; Tue, 1 Sep 2026 17:30:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 225D44BA2E27 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 225D44BA2E27 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=34.2.86.21 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788283850; cv=none; b=X+AtIkRQT6xXhu3jLrQ8CeTDybZK7UqnijujICPPoLFJa6f9DxhH7Y2LryGWACGgksB2hVWEEAHfXqWL6GhGt84vujd6aZ2Nct9B+OOVDiIHEkaRWhE6oO46uGHm741YwrTJb8wv2UfHZfBk8mkMHLqCd0U5XIMXJIBFMxg8/Ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788283850; c=relaxed/simple; bh=zuKaf59mGEZorIQBfkr4fuYUm3GYB8h7+yiAP/Xprrs=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=pLIon4O3JLtI+0cuFhvIqDI+p1tD85PbqLliP61wBDEX6dQF6vFQmBHZeMLAtghxxCFyyifqOLIKtwCc2Jti4QEzjTjf6lfp9AC5fW+rC5CJV3CXzozw6ruI8wKE9QQOjLYGeP2OWa5+m/AYhqh0WIPgKmB7CJJP80GhKmp29CA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=fAKz3iTt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 225D44BA2E27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1788283848; bh=zuKaf59mGEZorIQBfkr4fuYUm3GYB8h7+yiAP/Xprrs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=fAKz3iTtJEFIgqcf6Hr/lPB40kzlEJ9kIXTwZw8cTzHVhB+DvHtUyrmsj5Tgsr9xuMjuFVZ7lv1LcsRPDoOL54GiUUUT2vj23FTa2kELLO3SEtv8zVYVJNc5rmWKC6ZDiWKyIsy9Tsu6brrH+Kke3hwgokNIYUpp0BbUdTC35C26xg0ja5Se/d4c/f9cOzejIE7XIB4qXLYjV0ltKdOiCO2Zn8LisLbNeccJir4uxB954x4saxA8MwnyIF/7wLb9nLShbLGxW1ykJMUMHHJf/9DXiHtE+VHfe0R1vaNnaanF7zecO6mB3zhl1pDygFTuEUETziiePfVeWwT9O74lYA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1788283848; bh=lqMFd+BoXABXaKIuxXymzO6j5r7m14K2ml4A5+dOMyr=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=eAMY55xzsRgo4M7S7HiCbtvcvwnNLM0+jcF74hdefpy1+QA+lbCkPX9cfRIIFOrw+dLiZupxSSNPE8UeYHltggpAi3iR92nUlxWSe5lmhrsVn516zpaztrSd9j1ZN74JDC8c+vUvPwiiRedO/06ZedabhhoFvyfJnCVbDaMHN8glWXBUCJcFd60nZdY/qfVb7ZIb7HLQ2HsxAUxFUlWSxbdr62vA6g7+2Kldx2ZKGA5zynaB35yli0pglPz0Mw3zLNLfKEkkHM3kAeX2hZQJR8Syx+ZHgsxDlp7hPKUPQTlcajLFDAtMxfGi4+R6gW+MUSWS/Y414R5A3I/pSsWYDg== X-YMail-OSG: F6fAyoIVM1mpPJuqOljSZN5TGL_v0NLZnuZi.pahAVLhiFcnDgWdah3Ar5X6YqW tP3mP8o53YId84673XYg159qTmM5B.w_HoJonaAdP9EZMsZANMGHSlOc5SZJVp5N.1tOJaJW9uh1 yWFSAi58fpRg5wQleOaquQcO4A0BrW4x5YHaCSiGkuOfHFRLi6w_JZeaV8KJpdNsfyrY7R8ZYwOJ SQmq0CN56QXJf46kgk60tZ7KZbxbbVoh54j_wJ54uLvSiApSLWWaPatamyxuBpr05Ne0L6kF.3pa IK0xbOuV5y4Infu4jiEo6Mb4coimFNWqSzxwOnnWXcw_s7nWBRu26w5DDnGQN8xIcW1Ok6dfQuYF J97VKq1c41YQ78tonl5liKQ4p9Zo8QG4mOwebOXQY2ysf8Dn.s95o7R6jAEbAn4Y5I2BTbO1t83o nezPrVNsaBnBmPLKawpAGcgQ8c60aKGXH3RBi6HgmHD2Co_wYD3qz.QAoFOiy1LIH4lI8gEVExev TsElVfDV8AECJtmQJeXeD1tQvdu_pDtbD6tFDyRuWM78vVS51aLxkg_1mZEpYSMmlNyvwShi1bVk 6hBRTCr4c.2oUSWRIJS9ExcDwVGP5nF0w20f9nhKsrWRTfIIDP012XFfOqkUQlAXIhwWagk20kHr SWrIQmroIQI2oeJx85fiwRu5PQjzmWyAYHmNNFQZGs8L4ePRTJ5WoGEXiCG7flf3pZlf4yf2A12m aJ_tkDO7oozldKqZz13C3PIxwlLj0zacndpiri7nJsxcpSlW4ckFK.TdmAXJKjVeePvkaBPG6q5B m83FxDgl9P_p8Q0U5dlMETD9rtFMx5uZarsI.Q3jylrtDS1cMiKsYkZ8ARhCsCTjxLshzIseEkgy ff4Q5un8IwtRuAPUCexCyXVtbq5P5qOZKgZn0SGJzSaobhBGXGQkzsNPxq52GULy9Lcw0GmgDXzS 1prTAiHWipMdDbI23NRAn9FsScFx7cpUhvRpvLoPWbnIKDL842Nghl1KtisRGFO75KFv4PKPl3mk 27Jz3gFCV0ssZf51eEhRa5CxmToJmXxyLipow3Ga6D27sBHShVBN1QTuXOLJdIUWCroE.yCX6yCX L1.sa6EUNHbDkbfK8cjggIY0ZRDzMeLB89dBpOXmDEXrXGNn1ePdz6z9GC1S9XzUw5FOKiJ79ALD Uc76D2njV__6q.WRM6VrcJQbxBBdK4OwMaYh7sa2V6dDnCgi.QWRUvyvt4ouVaN1qBnty8E83sVD ka8FFkKz1rqH5_zxcUzTNl3Zneg4NvZR74J3Aeqpt8drKtkpqg4mKJvSkGn3YTczlmpGVT3QvT.N AjbDv10mq3s2NWfpmGw9jxkibnJd8KGyWx_c.FrmvaST51jtp2RRksqPvwGGfoMnA35xpB3Kj68w 87Vm2xlAlya.qDCLeEFVTVrqtXTG5IUVs1aUJ3mL1MQv3xlcNcW.UkLH2euBK7Qt8a573sTakPn3 2sjylwDMz1WJZI0mZz8YNb_UK67IrBr.jRP_SIfXr.bgs95MwmXmmXXD5sHrhi34bbOrro2tSzSr sDx2Hwo7apPg3Fxsw3ECQzZCfVnVE8b8m7waor6lA8LmozDPyv7GcHkC6vLQSBoybmopaluOuhtk 7QkPzmlL9y8WlgxlAg75joA.HtXW6KzLAf82zyN7vrSUQhSxFiVpuqzNHWC7lMpCrKBtbGQzn4GY t2QSM.8Al0biAsa9vcxMbT4ksZLVHedgtix1SMKqr8rkEvsploiw1NhIOG8hmrj8ZGSvve13y_.4 7hLuQsQg__tc8aqGswIzgzVYo96KnZCcpDc1Kc_kdJGmhOeH.TqkvBGffR8pBXocgB8vYXuU0afE 3Kj7qqz1jIRxkSVRElaV9iBMDBnbxPF5JiZit9nm8Fgl.K0.ciVyl1q8Gi.6o7F9FgT6SsGZvE45 xKTErEazp829oPecQXDywNxtJ_HPAI6gFNTGrPhEUBkDqYwTfMMYBG0XgGBVjyAPitQpXay2e_MY K7vzOdsTjOXVJ99fBSzAXdTouMKBZ2glDp8_WzNk1LM.1ADO_53ovapbkZsA5K3mHno3hQTavMPo - X-Sonic-MF: X-Sonic-ID: 84a14b14-b981-463a-8728-dd31b26688d7 Received: from sonic.gate.mail.ne1.yahoo.com by mail-asdoutdeli-p-cin-euwe4-prod-sonicconsumer-svc-101 with HTTP; Tue, 1 Sep 2026 17:30:48 +0000 Date: Tue, 1 Sep 2026 17:30:44 +0000 (UTC) From: Hannes Domani To: Tom Tromey Cc: "gdb-patches@sourceware.org" Message-ID: <1284549228.12706.1788283844741@mail.yahoo.com> In-Reply-To: <87a4q07uoh.fsf@tromey.com> References: <20260829145823.1034821-1-ssbssa@yahoo.de> <20260829145823.1034821-2-ssbssa@yahoo.de> <87a4q07uoh.fsf@tromey.com> Subject: Re: [PATCH v3 2/8] Windows gdb: Use allocated buffer for CONTEXT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.26460 YMailCLDNorrin X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Am Dienstag, 1. September 2026 um 19:22:59 MESZ hat Tom Tromey Folgendes geschrieben: > >>>>> "Hannes" =3D=3D Hannes Domani writes: >=C2=A0 > Hannes> This is done in preparation for the XState functions, because the > Hannes> extended registers are stored directly after the CONTEXT, and its= actual > Hannes> size depends on the available XState features. >=C2=A0 > Looks good, thanks.=C2=A0 I have one note but it's not really super > important. >=C2=A0 > Approved-By: Tom Tromey >=C2=A0 > Hannes> +windows_thread_info::windows_thread_info (windows_process_info *= proc_, > Hannes> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 DWORD tid_, HANDLE h_, CORE_ADDR tlb) > Hannes> +=C2=A0 : proc (proc_), > Hannes> +=C2=A0 =C2=A0 tid (tid_), > Hannes> +=C2=A0 =C2=A0 h (h_), > Hannes> +=C2=A0 =C2=A0 thread_local_base (tlb) > Hannes> +{ > Hannes> +#ifdef __x86_64__ > Hannes> +=C2=A0 if (proc->wow64_process) > Hannes> +=C2=A0 =C2=A0 { > Hannes> +=C2=A0 =C2=A0 =C2=A0 context_buffer.reset (xmalloc (sizeof (WOW6= 4_CONTEXT))); > Hannes> +=C2=A0 =C2=A0 =C2=A0 wow64_context =3D (WOW64_CONTEXT *) context= _buffer.get (); > Hannes> +=C2=A0 =C2=A0 } > Hannes> +=C2=A0 else > Hannes> +#endif > Hannes> +=C2=A0 =C2=A0 { > Hannes> +=C2=A0 =C2=A0 =C2=A0 context_buffer.reset (xmalloc (sizeof (CONT= EXT))); > Hannes> +=C2=A0 =C2=A0 =C2=A0 context =3D (CONTEXT *) context_buffer.get = (); > Hannes> +=C2=A0 =C2=A0 } > Hannes> +=C2=A0 *proc->context_flags_ptr (this) =3D 0; >=C2=A0 > I guess this is because the memory isn't initialized? > You could use XCNEW instead of xmalloc to fix this. It's not just because of uninitialized memory from malloc. Patch 6 then introduces InitializeContext, which actually initializes context_flags to CONTEXT_ALL | CONTEXT_XSTATE, so it has to be reset to 0 anyways. Thanks Hannes