Re: [PATCH 17/26] gdbserver: rename regcache's registers_valid to registers_fetched

Simon Marchi
2023-12-22T03:24:03Z

On 2023-02-28 06:28, Tankut Baris Aktemur via Gdb-patches wrote:
> The registers_valid field of the regcache struct is used for tracking
> whether we have attempted to fetch all the registers from the target.
> Its name does not reflect this well, I think. It falsely gives the
> impression that all the registers are valid. This may conflict an
> individual register status, which could be REG_UNAVAILABLE. To better
> reflect the purpose, rename the field to "registers_fetched".

I agree that the term valid is used for both things here. I'm fine with
the change. Again, I think that can be pushed right away.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon