Re: [RFA] (Ada/ravenscar) error during "continue" after task/thread switch

[Pedro Alves <palves@redhat.com>]

Hi Joel,

The change to top.c looks right regardless of having been noticed
on ravenscar only so far.  I can imagine other scenarios where this
would be necessary even on GNU/Linux.

So LGTM, with minor nits below fixed.

On 04/23/2018 10:51 PM, Joel Brobecker wrote:
>        + swtich inferior_ptid to the ptid of the actually active thread;

>     checks to see if the language may no longer be maching the current

> in cases the inferior isn't running. Otherwise, it skips it, knowning
My Thunderbird noticed these typos above:

 swtich -> switch
 maching -> matching
 knowning -> knowing

> diff --git a/gdb/top.c b/gdb/top.c
> index 8903a92..0480726 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -642,7 +642,12 @@ execute_command (const char *p, int from_tty)
>  	}
>      }
>  
> -  check_frame_language_change ();
> +  /* Only perform the frame-language-change check unless the command
> +     we just finished executing did not resume the inferior's execution.
> +     If it did resume the inferior, we will do that check after
> +     the inferior stopped.  */

"only ... unless ... did not" sounds odd.  Did you mean:

 -  /* Only perform the frame-language-change check unless the command
 +  /* Only perform the frame-language-change check if the command
       we just finished executing did not resume the inferior's execution.
       If it did resume the inferior, we will do that check after
       the inferior stopped.  */

?

> +  if (has_stack_frames () && !is_running (inferior_ptid))
> +     check_frame_language_change ();


Please double-check indentation of the
check_frame_language_change call line.

Thanks,
Pedro Alves