From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cbdKCGg8HWDxHgAAWB0awg (envelope-from ) for ; Fri, 05 Feb 2021 07:39:04 -0500 Received: by simark.ca (Postfix, from userid 112) id 0766B1EFCB; Fri, 5 Feb 2021 07:39:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 720C51E590 for ; Fri, 5 Feb 2021 07:39:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B90053971422; Fri, 5 Feb 2021 12:39:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B90053971422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612528742; bh=NL9NOz/t9e+HTEGRO5W5gGMrKsUHz0c9irx/155xASo=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wti5nmt1gLY5eWMia+zjTeAw4f3QO+u2As9Z4sNJgUdwnss+0pe7M17fvDYf05SMj cbfmq5WCkXVQvqkHUqsVbXFcUKMUgcK8OlFTR96EMTDaRGDKd40rcYyASPwi/AN5tl Cs4M2Sebff2QnTw4xGnK9k8td3aRuQQzEtLWZdHk= Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id B204E38618FC for ; Fri, 5 Feb 2021 12:38:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B204E38618FC Received: by mail-qt1-x836.google.com with SMTP id d15so4764742qtw.12 for ; Fri, 05 Feb 2021 04:38:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NL9NOz/t9e+HTEGRO5W5gGMrKsUHz0c9irx/155xASo=; b=SeWWbZkG0S9AvJ66qhQMzCJEIc/AKsV6TXT6cfb0MHa0DMAPkvkuJp8t22LlfvkDaE 5xZQ0Guu9ge3aek6Jo+81ACDEQbelnzzHYYOqWUClfceZHFBNofIk9+DFoQ6EMsV/g+I cgjVItfBZ1Hd7GSf73bNkDQrEoatQBTCgIIuDaJsILoUxHXe9TnKyKySdgnEfqDuhatU tbeSHZOlPhY10NFYmr7ukY4vYJ5loBiq/4E5B3Tk2z8TwYVhv3YDt/ngGT6FViUlK78i y0gMHmTljuFPog2Zied3aZVtNOKiHVT+7sg38jFyhwCPy5EUAmxTsxmwW4fNkkvzsack 4wuw== X-Gm-Message-State: AOAM530VV/Cwh07j7V9AIrJeoUDZN6lA3crb6SAmTWun3axT2QcGNpac JLmpedDoxAZEl+xPI7XdQKOWpmOzmqHL6Q== X-Google-Smtp-Source: ABdhPJzml+L9XVw194N7A2TXT+m19H5LO1bIesDDeFTugOSsrByIrI6FvRmkacuZMhj0yXYcd7V7aQ== X-Received: by 2002:ac8:480b:: with SMTP id g11mr3928416qtq.290.1612528738995; Fri, 05 Feb 2021 04:38:58 -0800 (PST) Received: from ?IPv6:2804:7f0:8284:848d:5d42:306c:a572:c6bb? ([2804:7f0:8284:848d:5d42:306c:a572:c6bb]) by smtp.gmail.com with ESMTPSA id z23sm4795084qkb.13.2021.02.05.04.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Feb 2021 04:38:58 -0800 (PST) Subject: Re: [PATCH v5 05/25] GDBserver remote packet support for memory tagging To: Simon Marchi , gdb-patches@sourceware.org References: <20210127202112.2485702-1-luis.machado@linaro.org> <20210127202112.2485702-6-luis.machado@linaro.org> Message-ID: <12711994-9c67-ef67-5e25-e68a1c279447@linaro.org> Date: Fri, 5 Feb 2021 09:38:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2/4/21 11:56 PM, Simon Marchi wrote: >> diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc >> index cfdf1c1883..4e76f08ac5 100644 >> --- a/gdbserver/remote-utils.cc >> +++ b/gdbserver/remote-utils.cc >> @@ -1304,10 +1304,14 @@ prepare_resume_reply (char *buf, ptid_t ptid, >> } >> } >> >> -void >> -decode_m_packet (char *from, CORE_ADDR *mem_addr_ptr, unsigned int *len_ptr) >> +/* Decode ADDR and LEN from a parameter of the form "addr,len", with >> + being an end marker character. */ >> + >> +const char * >> +decode_m_packet_params (const char *from, CORE_ADDR *mem_addr_ptr, >> + unsigned int *len_ptr, const char end_marker) > > For new code, IWBN to follow the convention of putting the doc in the > header, and putting /* See remote-utils.h. */ here. > > Otherwise, LGTM. Thanks. I noticed the documentation is off. I updated it and moved it to the header file.