From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2972 invoked by alias); 24 Jan 2020 14:36:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2946 invoked by uid 89); 24 Jan 2020 14:36:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 14:36:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1579876601; bh=/JBR1v5y98sqDUoWWGC0MK/hVpSWCU/mtKR8ORJ5hPU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=N4HZvoKjVGRjZ1I9P7F5R/OIFiDIwm+2qno0o76va/Ck3EOmcQ8TpwBe8BsxZSrOl 9OR6ugFOsvCS6RyIp2jT9i1PSmyjb7pglY8OOz7oRxHI4RO4z2lmLSCF5oH8cXqG9Q euN3UnMPT6Xw/tSgRwEvM4fePLaGWiJIRKjQ/YaI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.71.135.231]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MG9kC-1ipZ4v1RSG-00Gb3M; Fri, 24 Jan 2020 15:36:41 +0100 Subject: Re: [PATCH 3/3] Make the class name in the definition match the declaration To: cbiesinger@chromium.org, gdb-patches@sourceware.org Cc: Christian Biesinger References: <20200124141458.171392-1-cbiesinger@chromium.org> <20200124141458.171392-4-cbiesinger@chromium.org> From: Kamil Rytarowski Message-ID: <126cff6f-20ad-25f1-5fa1-47887d5379da@gmx.com> Date: Fri, 24 Jan 2020 14:54:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200124141458.171392-4-cbiesinger@chromium.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DWH8EHn1fUnF2M8s2DkmGj1uD6rb4bi85" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00795.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DWH8EHn1fUnF2M8s2DkmGj1uD6rb4bi85 Content-Type: multipart/mixed; boundary="9i3gNXmlMjmrUgSbOL1HCz6TBfPMRlXCd"; protected-headers="v1" From: Kamil Rytarowski To: cbiesinger@chromium.org, gdb-patches@sourceware.org Cc: Christian Biesinger Message-ID: <126cff6f-20ad-25f1-5fa1-47887d5379da@gmx.com> Subject: Re: [PATCH 3/3] Make the class name in the definition match the declaration References: <20200124141458.171392-1-cbiesinger@chromium.org> <20200124141458.171392-4-cbiesinger@chromium.org> In-Reply-To: <20200124141458.171392-4-cbiesinger@chromium.org> --9i3gNXmlMjmrUgSbOL1HCz6TBfPMRlXCd Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1504 On 24.01.2020 15:14, cbiesinger@chromium.org wrote: > From: Christian Biesinger >=20 > Fixes a compile error because the class is actually called > arm_netbsd_nat_target. >=20 > gdb/ChangeLog: >=20 > 2020-01-24 Christian Biesinger >=20 > * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to... > (arm_netbsd_nat_target::fetch_registers): ...this. > (arm_nbsd_nat_target::store_registers): Rename to... > (arm_netbsd_nat_target::store_registers): ...this. >=20 Looks fine. Personally I am for unwinding the 'nbsd' term in GDB more widely in more places. > Change-Id: Ibebfab9edeff48f54c32d0745afda1d74d31de92 > --- > gdb/arm-nbsd-nat.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c > index 31fe66c724..5072bd09ec 100644 > --- a/gdb/arm-nbsd-nat.c > +++ b/gdb/arm-nbsd-nat.c > @@ -191,7 +191,7 @@ fetch_fp_regs (struct regcache *regcache) > } >=20=20 > void > -arm_nbsd_nat_target::fetch_registers (struct regcache *regcache, int reg= no) > +arm_netbsd_nat_target::fetch_registers (struct regcache *regcache, int r= egno) > { > if (regno >=3D 0) > { > @@ -380,7 +380,7 @@ store_fp_regs (const struct regcache *regcache) > } >=20=20 > void > -arm_nbsd_nat_target::store_registers (struct regcache *regcache, int reg= no) > +arm_netbsd_nat_target::store_registers (struct regcache *regcache, int r= egno) > { > if (regno >=3D 0) > { >=20 --9i3gNXmlMjmrUgSbOL1HCz6TBfPMRlXCd-- --DWH8EHn1fUnF2M8s2DkmGj1uD6rb4bi85 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl4rAMUACgkQS7MI6bAu dmzvrA/+O0tV2E/xs2TAVjfCFXKJlil4fag6ZOHSb5Su2/05i1Gq+FUiGuHO0a4d Of9eSd+N7JOhRlRiIr1YPAc5LRgCnnnLU31PgrGsOs7pFpnwiw7DQE+Y1e1wz3Dc uRBAtPy7LnTkAka7DY6VquI3MfYxQ7+4tjIvRTTM+iu7Fi7c0rXJ1x7vX0unvlH6 ICC8oLdPgzYLuSuLqUO+137S8du6T+ORZ7Fsu6N3euCRO889rnTREZw6lwJ+1/6t pxq8ziMft2iisfMq895UEJXxEBAH3PFKSiiu5iamF7VKuC5fDdoeSl2soyF9Oims 6l5Qf9Mhc6rUTAjZIPjKy3obG9bvOLCByAIMj7rANsf0T/kMijChSZW2XGjh5Fqs KIQDDOnIrKVOXyiSG7AEDsNbqJjk8tYUyfuaqEvYuhtvrwGULHNfY8z3SDMBgE53 KuDt7mfY1qMlaZ16XXBywkhgFMA84ydg3GvxXLSqQirLLL4+uxtgYWiqyqgcqaFJ 9WF1DfYbEaDE6E28zyifV6PeGu/0rFhwZkqoVuSzUtsn3G0LMUROBTVZ6z+dn50s 5ZTFuYbQ3dR1rLShcdW8x3+vADq7WmE4GLt1uOV2hXaRVqw0aUk55jQ9niLYHi0l 631vV1xHIGd9VUMCi0wYeknqby/lWh/EaBDBLpPS5hAwapgoNCc= =tnX7 -----END PGP SIGNATURE----- --DWH8EHn1fUnF2M8s2DkmGj1uD6rb4bi85--