Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH v2] sim: fix printf format warning about non-string literal
Date: Mon, 29 Mar 2010 23:11:00 -0000	[thread overview]
Message-ID: <1269904298-11420-1-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1269903237-11061-1-git-send-email-vapier@gentoo.org>

This is the normal "passing a buffer straight to printf makes GCC warn".
While we know this particular case is fine, the trend in this source tree
is to fix this anyways to avoid the warnings.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
	- also fix same issue in hw_option_handler()

2010-03-29  Mike Frysinger  <vapier@gentoo.org>

	* sim-utils.c (sim_io_eprintf_cpu): Use %s with printf string.
	* sim-hw.c (hw_option_handler): Likewise.

 sim/common/sim-hw.c    |    2 +-
 sim/common/sim-utils.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c
index d9868d3..7481492 100644
--- a/sim/common/sim-hw.c
+++ b/sim/common/sim-hw.c
@@ -257,7 +257,7 @@ hw_option_handler (struct sim_state *sd, sim_cpu *cpu, int opt,
 
     case OPTION_HW_DEVICE:
       {
-	hw_tree_parse (STATE_HW (sd)->tree, arg);
+	hw_tree_parse (STATE_HW (sd)->tree, "%s", arg);
 	return SIM_RC_OK;
       }
 
diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c
index fb84eb3..9f9104e 100644
--- a/sim/common/sim-utils.c
+++ b/sim/common/sim-utils.c
@@ -170,7 +170,7 @@ sim_io_eprintf_cpu (sim_cpu *cpu, const char *fmt, ...)
   va_list ap;
 
   va_start (ap, fmt);
-  sim_io_eprintf (sd, sim_cpu_msg_prefix (cpu));
+  sim_io_eprintf (sd, "%s", sim_cpu_msg_prefix (cpu));
   sim_io_evprintf (sd, fmt, ap);
   va_end (ap);
 }
-- 
1.7.0.2


  reply	other threads:[~2010-03-29 23:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 22:54 [PATCH] " Mike Frysinger
2010-03-29 23:11 ` Mike Frysinger [this message]
2010-03-30 16:50   ` [PATCH v2] " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269904298-11420-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox