From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14426 invoked by alias); 19 Mar 2010 02:09:23 -0000 Received: (qmail 14411 invoked by uid 22791); 19 Mar 2010 02:09:21 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Mar 2010 02:09:18 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id BB0501B40AA for ; Fri, 19 Mar 2010 02:09:15 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH] gdb: fix sparc memcpy fortify error Date: Fri, 19 Mar 2010 02:09:00 -0000 Message-Id: <1268964549-30380-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00715.txt.bz2 Building on an x86_64-linux system with --enable-targets=all fails on the sparc code with a fortify error: cc1: warnings being treated as errors In file included from /usr/include/string.h:640, from gnulib/string.h:23, from ../../gdb/gdb_string.h:25, from ../../gdb/vec.h:25, from ../../gdb/memattr.h:24, from ../../gdb/target.h:60, from ../../gdb/exec.h:23, from ../../gdb/gdbcore.h:31, from ../../gdb/sparc-tdep.c:29: In function 'memcpy', inlined from 'sparc32_store_return_value' at ../../gdb/sparc-tdep.c:1112, inlined from 'sparc32_return_value' at ../../gdb/sparc-tdep.c:1170: /usr/include/bits/string3.h:52: error: call to __builtin___memcpy_chk will always overflow destination buffer make: *** [sparc-tdep.o] Error 1 So have the buffer be the max of the lengths used with memcpy(). Signed-off-by: Mike Frysinger --- 2010-03-18 Mike Frysinger * gdb/sparc-tdep.c (sparc32_store_return_value): Declare the length of buf using the "len" variable. gdb/sparc-tdep.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c index f129a55..ea0cdd2 100644 --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -1101,7 +1101,7 @@ sparc32_store_return_value (struct type *type, struct regcache *regcache, const gdb_byte *valbuf) { int len = TYPE_LENGTH (type); - gdb_byte buf[8]; + gdb_byte buf[max(len, 8)]; gdb_assert (!sparc_structure_or_union_p (type)); gdb_assert (!(sparc_floating_p (type) && len == 16)); -- 1.7.0.2