From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19672 invoked by alias); 4 Feb 2010 22:33:04 -0000 Received: (qmail 19652 invoked by uid 22791); 4 Feb 2010 22:33:03 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from p3plsmtpa01-06.prod.phx3.secureserver.net (HELO p3plsmtpa01-06.prod.phx3.secureserver.net) (72.167.82.86) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Thu, 04 Feb 2010 22:32:59 +0000 Received: (qmail 23247 invoked from network); 4 Feb 2010 22:32:58 -0000 Received: from unknown (99.226.65.232) by p3plsmtpa01-06.prod.phx3.secureserver.net (72.167.82.86) with ESMTP; 04 Feb 2010 22:32:58 -0000 Subject: [patch, moxie] Fail prologue analysis gracefully From: Anthony Green To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="=-xF8uU2ohNB9gTocxNHif" Date: Thu, 04 Feb 2010 22:33:00 -0000 Message-ID: <1265322776.3047.1.camel@localhost> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00146.txt.bz2 --=-xF8uU2ohNB9gTocxNHif Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 123 My prologue analyzer was looping forever on some hand-written assembly. Here's the fix, which I am about to commit... AG --=-xF8uU2ohNB9gTocxNHif Content-Disposition: attachment; filename="moxie-gdb.patch" Content-Type: text/x-patch; name="moxie-gdb.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 592 2010-02-04 Anthony Green * moxie-tdep.c (moxie_analyze_prologue): Fail protocol analysis gracefully. Index: moxie-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/moxie-tdep.c,v retrieving revision 1.8 diff -u -r1.8 moxie-tdep.c --- moxie-tdep.c 1 Jan 2010 07:31:37 -0000 1.8 +++ moxie-tdep.c 4 Feb 2010 22:24:29 -0000 @@ -174,6 +174,8 @@ cache->saved_regs[regnum] = cache->framesize; next_addr += 2; } + else + break; } inst = read_memory_unsigned_integer (next_addr, 2, byte_order); --=-xF8uU2ohNB9gTocxNHif--