From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71773 invoked by alias); 28 Jan 2020 17:16:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71763 invoked by uid 89); 28 Jan 2020 17:16:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-HELO:sk:sonic31, H*x:5.0, H*x:Windows X-HELO: sonic314-19.consmr.mail.ir2.yahoo.com Received: from sonic314-19.consmr.mail.ir2.yahoo.com (HELO sonic314-19.consmr.mail.ir2.yahoo.com) (77.238.177.145) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Jan 2020 17:16:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1580231769; bh=45Lg0Uy22q8ba96u5NfFpL7rzCLIx2DX7mvYXKm675s=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=OLGCAsMeugwP0Hjw/HqRjv3nQ2VNeMGZb0ugPc//RbIskiVYMWHTQ+Mt+wDatOy6XqvuJpz0DcYgRjoTIPr1W2i00HM4bZ5iVHdbJmrEuXSjQlloTSgdIyUQWeLksmzTMjRAai2CRaMdc9gm7hCgC8Ifi88fL03qskk8V1F7umCJi5A/XNBMSrhXzBf0mvwMF0ZZOx1KstOh4XAHGvKhg3keBrmw/06Wba7/kPT0gYGrB4PMcSbIu6AbKgWEhVowEuWZ9r4q7ON1gunu/qLrLzFz+CrMQ/k/A7Kehl0t6kCtPlVKwQncSuClJLSGfkyLtV+sOP+Whi0x8pe6Qdiicg== Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Tue, 28 Jan 2020 17:16:09 +0000 Date: Tue, 28 Jan 2020 17:37:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <1263914100.758181.1580231765645@mail.yahoo.com> In-Reply-To: References: <20200126114033.GA20733@adacore.com> <720913399.742914.1580230424544@mail.yahoo.com> Subject: Re: Propose we release GDB 9.1 next weekend (Feb 01-02) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00909.txt.bz2 Am Dienstag, 28. Januar 2020, 18:13:15 MEZ hat Simon Marchi Folgendes geschrieben: > On 2020-01-28 11:53 a.m., Hannes Domani via gdb-patches wrote: > > I just noticed that gdbserver is a bit broken for x86_64-mingw (and I t= hink > > it always was).> > > Reason for it is this part in gdbserver/server.c: > > > >=C2=A0=C2=A0=C2=A0=C2=A0 document +=3D string_printf > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("=C2=A0 \n", > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dll.name.c_str (), (long) dll= .base_addr); > > > > (long) is always 32bit on Windows, so the upper bits are cut off. > > Indeed.=C2=A0 That code went through several refactors, but originally it= was introduced > by this 2007 commit: > >=C2=A0=C2=A0 https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;a= =3Dcommit;h=3D255e7678a93693bd4d16cc3246442a1b8e11064e > > which has this line: > >=C2=A0=C2=A0 sprintf (p, "0x%lx", (long) dll->base_addr); > > So I think the bug has been there forever. > > > > Fix seems simple: > > > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 document +=3D string_printf > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("=C2=A0 \n", > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dll.name.c_str (), (long) dll.bas= e_addr); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("=C2=A0 \n", > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dll.name.c_str (), paddress (dll.= base_addr)); > > > > I just tested it and this improves the debugging experience a lot. > > > > But I guess this is probably too late for the release. > > > I don't think it so, we can always push fixes to the release branch.=C2= =A0 This one > seems desirable and not risky at all, so I think it would be fine.=C2=A0 = Would you > be willing to submit a complete patch for this? Yes, I will do that. Regards Hannes Domani