Re: [PATCH 1/4] Support the new BookE ptrace interface

Ulrich Weigand
2010-02-23T19:07:47Z

Thiago Jung Bauermann wrote:

> Good point. This version adds a have_ptrace_booke_interface function that
> is called whenever we need to check for support of the booke ptrace
> interface.

Thanks!

> This patch was approved before the 7.1 branch was created, but I didn't
> commit it then because the kernel support wasn't committed upstream yet.
> It is in the linux-next tree as of last friday, and will appear in 2.6.34.
> Can I commit this patch both for the 7.1 branch and HEAD?

Another problem just occurred to me, sorry for not noticing on the last
review: It seems the memory allocated in ppc_linux_new_thread is never
freed, or is it? Re-running the same inferior (with all different TID
values) would then leak a bit of memory ...

I guess this memory should be freed in a thread_exit notifier.

With this change, the patch would be OK for HEAD.
For the branch, Joel has the last word ...

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com