From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25423 invoked by alias); 15 Jan 2010 17:41:37 -0000 Received: (qmail 25406 invoked by uid 22791); 15 Jan 2010 17:41:31 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jan 2010 17:41:24 +0000 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by e24smtp04.br.ibm.com (8.14.3/8.13.1) with ESMTP id o0FHUk2g032286 for ; Fri, 15 Jan 2010 15:30:46 -0200 Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o0FHfKQC4047016 for ; Fri, 15 Jan 2010 14:41:20 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o0FHfJ1x004379 for ; Fri, 15 Jan 2010 15:41:19 -0200 Received: from [9.8.11.131] ([9.8.11.131]) by d24av04.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id o0FHfIBl004356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 15 Jan 2010 15:41:18 -0200 Subject: Re: [PATCH 1/4] Support the new BookE ptrace interface From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Joel Brobecker Cc: Thiago Jung Bauermann , gdb-patches@sourceware.org, Matt Tyrlik In-Reply-To: <20100105045130.GA24777@adacore.com> References: <200912232230.56227.bauerman@br.ibm.com> <200912311518.14325.bauerman@br.ibm.com> <20100105045130.GA24777@adacore.com> Content-Type: multipart/mixed; boundary="=-u6zmNzt1Zjf/fx1bo/+s" Date: Fri, 15 Jan 2010 17:41:00 -0000 Message-ID: <1263577277.2967.4.camel@gargoyle> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00407.txt.bz2 --=-u6zmNzt1Zjf/fx1bo/+s Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 788 Patch updated with the fixes. Regards, Luis > Still looks good to me :). Just a couple of nits, but otherwise approved. > It would still be nice if Ulrich had a chance to take a quick look ;-). > > > +struct ppc_debug_info { > > + uint32_t version; /* Only version 1 exists to date */ > > The curly brace should be at the beginning of the next line. > And the indentation (probably a copy-paste from the kernel headers?) > needs to be adjusted. > > Not that it really matters a whole lot. For this section, if it makes > things simpler to preserve the indentation of the original, I could > be convinced to leave the code untouched. > > > +static int get_trigger_type (int rw) > > Formatting nit as well: > > static int > get_trigger_type (int rw) > --=-u6zmNzt1Zjf/fx1bo/+s Content-Disposition: attachment; filename="ppc476-new-interface.diff" Content-Type: text/x-patch; name="ppc476-new-interface.diff"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 23652 2009-12-23 Sergio Durigan Junior Thiago Jung Bauermann * ppc-linux-nat.c (PTRACE_GET_DEBUGREG): Update comment. (PPC_PTRACE_GETWDBGINFO, PPC_PTRACE_SETHWDEBUG, PPC_PTRACE_DELHWDEBUG, ppc_debug_info, PPC_DEBUG_FEATURE_INSN_BP_RANGE, PPC_DEBUG_FEATURE_INSN_BP_MASK, PPC_DEBUG_FEATURE_DATA_BP_RANGE, PPC_DEBUG_FEATURE_DATA_BP_MASK, ppc_hw_breakpoint, PPC_BREAKPOINT_TRIGGER_EXECUTE, PPC_BREAKPOINT_TRIGGER READ, PPC_BREAKPOINT_TRIGGER_WRITE, PPC_BREAKPOINT_TRIGGER_RW, PPC_BREAKPOINT_MODE_EXACT PPC_BREAKPOINT_MODE_RANGE_INCLUSIVE, PPC_BREAKPOINT_MODE_RANGE_EXCLUSIVE, PPC_BREAKPOINT_MODE_MASK, PPC_BREAKPOINT_CONDITION_NONE, PPC_BREAKPOINT_CONDITION_AND, PPC_BREAKPOINT_CONDITION_EXACT, PPC_BREAKPOINT_CONDITION_OR, PPC_BREAKPOINT_CONDITION_AND_OR, PPC_BREAKPOINT_CONDITION_BE_ALL, PPC_BREAKPOINT_CONDITION_BE_SHIFT, PPC_BREAKPOINT_CONDITION_BE): Define, in case doesn't provide it. (have_ptrace_new_debug_booke): New flag. (ppc_linux_check_watch_resources): Renamed to ... (ppc_linux_can_use_hw_breakpoint): ... this. Handle BookE processors. (booke_debug_info): New variable. (max_slots_number): Ditto. (struct hw_break_tuple): New struct. (struct thread_points): Ditto. (ppc_threads): New variable. (PPC_DEBUG_CURRENT_VERSION): New define. (ppc_linux_region_ok_for_hw_watchpoint): Handle BookE processors. (booke_cmp_hw_point): New function. (booke_find_thread_points_by_tid): Ditto. (booke_insert_point): Ditto. (booke_remove_point): Ditto. (ppc_linux_insert_hw_breakpoint): Ditto. (ppc_linux_remove_hw_breakpoint): Ditto. (HW_WATCH_RW_TRIGGER): New define. (ppc_linux_insert_watchpoint): Handle BookE processors. (ppc_linux_remove_watchpoint): Ditto. (ppc_linux_new_thread): Ditto. (ppc_linux_stopped_data_address): Ditto. (ppc_linux_watchpoint_addr_within_range): Ditto. with and without the new kernel interface. (ppc_linux_read_description): Query the target to know if it supports the new kernel BookE interface. (_initialize_ppc_linux_nat): Initialize to_insert_hw_breakpoint and to_remove_hw_breakpoint fields of the target operations struct. Index: gdb/gdb/ppc-linux-nat.c =================================================================== --- gdb.orig/gdb/ppc-linux-nat.c 2010-01-15 15:12:21.698527461 -0200 +++ gdb/gdb/ppc-linux-nat.c 2010-01-15 15:36:21.935565550 -0200 @@ -100,7 +100,8 @@ #define PTRACE_SETEVRREGS 21 #endif -/* Similarly for the hardware watchpoint support. */ +/* Similarly for the hardware watchpoint support. These requests are used + when the BookE kernel interface is not available. */ #ifndef PTRACE_GET_DEBUGREG #define PTRACE_GET_DEBUGREG 25 #endif @@ -111,6 +112,73 @@ #define PTRACE_GETSIGINFO 0x4202 #endif +/* These requests are used when the BookE kernel interface is available. + It exposes the additional debug features of BookE processors, such as + ranged breakpoints and watchpoints and hardware-accelerated condition + evaluation. */ +#ifndef PPC_PTRACE_GETHWDBGINFO + +/* Not having PPC_PTRACE_GETHWDBGINFO defined means that the new BookE + interface is not present in ptrace.h, so we'll have to pretty much include + it all here so that the code at least compiles on older systems. */ +#define PPC_PTRACE_GETHWDBGINFO 0x89 +#define PPC_PTRACE_SETHWDEBUG 0x88 +#define PPC_PTRACE_DELHWDEBUG 0x87 + +struct ppc_debug_info +{ + uint32_t version; /* Only version 1 exists to date */ + uint32_t num_instruction_bps; + uint32_t num_data_bps; + uint32_t num_condition_regs; + uint32_t data_bp_alignment; + uint32_t sizeof_condition; /* size of the DVC register */ + uint64_t features; +}; + +/* Features will have bits indicating whether there is support for: */ +#define PPC_DEBUG_FEATURE_INSN_BP_RANGE 0x1 +#define PPC_DEBUG_FEATURE_INSN_BP_MASK 0x2 +#define PPC_DEBUG_FEATURE_DATA_BP_RANGE 0x4 +#define PPC_DEBUG_FEATURE_DATA_BP_MASK 0x8 + +struct ppc_hw_breakpoint +{ + uint32_t version; /* currently, version must be 1 */ + uint32_t trigger_type; /* only some combinations allowed */ + uint32_t addr_mode; /* address match mode */ + uint32_t condition_mode; /* break/watchpoint condition flags */ + uint64_t addr; /* break/watchpoint address */ + uint64_t addr2; /* range end or mask */ + uint64_t condition_value; /* contents of the DVC register */ +}; + +/* Trigger type. */ +#define PPC_BREAKPOINT_TRIGGER_EXECUTE 0x1 +#define PPC_BREAKPOINT_TRIGGER_READ 0x2 +#define PPC_BREAKPOINT_TRIGGER_WRITE 0x4 +#define PPC_BREAKPOINT_TRIGGER_RW 0x6 + +/* Address mode. */ +#define PPC_BREAKPOINT_MODE_EXACT 0x0 +#define PPC_BREAKPOINT_MODE_RANGE_INCLUSIVE 0x1 +#define PPC_BREAKPOINT_MODE_RANGE_EXCLUSIVE 0x2 +#define PPC_BREAKPOINT_MODE_MASK 0x3 + +/* Condition mode. */ +#define PPC_BREAKPOINT_CONDITION_NONE 0x0 +#define PPC_BREAKPOINT_CONDITION_AND 0x1 +#define PPC_BREAKPOINT_CONDITION_EXACT 0x1 +#define PPC_BREAKPOINT_CONDITION_OR 0x2 +#define PPC_BREAKPOINT_CONDITION_AND_OR 0x3 +#define PPC_BREAKPOINT_CONDITION_BE_ALL 0x00ff0000 +#define PPC_BREAKPOINT_CONDITION_BE_SHIFT 16 +#define PPC_BREAKPOINT_CONDITION_BE(n) \ + (1<<((n)+PPC_BREAKPOINT_CONDITION_BE_SHIFT)) +#endif /* PPC_PTRACE_GETHWDBGINFO */ + + + /* Similarly for the general-purpose (gp0 -- gp31) and floating-point registers (fp0 -- fp31). */ #ifndef PTRACE_GETREGS @@ -248,6 +316,10 @@ them and gotten an error. */ int have_ptrace_getsetfpregs = 1; +/* Non-zero if we support the new Kernel interface that enables + new BOOKE debugging resources. */ +int have_ptrace_new_debug_booke = 1; + /* *INDENT-OFF* */ /* registers layout, as presented by the ptrace interface: PT_R0, PT_R1, PT_R2, PT_R3, PT_R4, PT_R5, PT_R6, PT_R7, @@ -1270,30 +1342,6 @@ store_spe_register (regcache, tid, -1); } -static int -ppc_linux_check_watch_resources (int type, int cnt, int ot) -{ - int tid; - ptid_t ptid = inferior_ptid; - - /* DABR (data address breakpoint register) is optional for PPC variants. - Some variants have one DABR, others have none. So CNT can't be larger - than 1. */ - if (cnt > 1) - return 0; - - /* We need to know whether ptrace supports PTRACE_SET_DEBUGREG and whether - the target has DABR. If either answer is no, the ptrace call will - return -1. Fail in that case. */ - tid = TIDGET (ptid); - if (tid == 0) - tid = PIDGET (ptid); - - if (ptrace (PTRACE_SET_DEBUGREG, tid, 0, 0) == -1) - return 0; - return 1; -} - /* Fetch the AT_HWCAP entry from the aux vector. */ unsigned long ppc_linux_get_hwcap (void) { @@ -1305,6 +1353,99 @@ return 0; } +/* The cached DABR value, to install in new threads. + This variable is used when we are dealing with non-BookE + processors. */ +static long saved_dabr_value; + +/* Global structure that will store information about the available + features on this BookE processor. */ +static struct ppc_debug_info booke_debug_info; + +/* Global variable that holds the maximum number of slots that the + kernel will use. This is only used when the processor is BookE. */ +static size_t max_slots_number = 0; + +struct hw_break_tuple +{ + long slot; + struct ppc_hw_breakpoint *hw_break; +}; + +/* This is an internal VEC created to store information about *points inserted + for each thread. This is used for BookE processors. */ +typedef struct thread_points + { + /* The TID to which this *point relates. */ + int tid; + /* Information about the *point, such as its address, type, etc. + + Each element inside this vector corresponds to a hardware + breakpoint or watchpoint in the thread represented by TID. The maximum + size of these vector is MAX_SLOTS_NUMBER. If the hw_break element of + the tuple is NULL, then the position in the vector is free. */ + struct hw_break_tuple *hw_breaks; + } *thread_points_p; +DEF_VEC_P (thread_points_p); + +VEC(thread_points_p) *ppc_threads = NULL; + +/* The version of the kernel interface that we will use if the processor is + BookE. */ +#define PPC_DEBUG_CURRENT_VERSION 1 + +static int +ppc_linux_can_use_hw_breakpoint (int type, int cnt, int ot) +{ + int total_hw_wp, total_hw_bp; + + if (have_ptrace_new_debug_booke) + { + /* For PPC BookE processors, the number of available hardware + watchpoints and breakpoints is stored at the booke_debug_info + struct. */ + total_hw_bp = booke_debug_info.num_instruction_bps; + total_hw_wp = booke_debug_info.num_data_bps; + } + else + { + /* For PPC server processors, we accept 1 hardware watchpoint and 0 + hardware breakpoints. */ + total_hw_bp = 0; + total_hw_wp = 1; + } + + if (type == bp_hardware_watchpoint || type == bp_read_watchpoint + || type == bp_access_watchpoint || type == bp_watchpoint) + { + if (cnt > total_hw_wp) + return -1; + } + else if (type == bp_hardware_breakpoint) + { + if (cnt > total_hw_bp) + return -1; + } + + if (!have_ptrace_new_debug_booke) + { + int tid; + ptid_t ptid = inferior_ptid; + + /* We need to know whether ptrace supports PTRACE_SET_DEBUGREG and whether + the target has DABR. If either answer is no, the ptrace call will + return -1. Fail in that case. */ + tid = TIDGET (ptid); + if (tid == 0) + tid = PIDGET (ptid); + + if (ptrace (PTRACE_SET_DEBUGREG, tid, 0, 0) == -1) + return 0; + } + + return 1; +} + static int ppc_linux_region_ok_for_hw_watchpoint (CORE_ADDR addr, int len) { @@ -1312,89 +1453,342 @@ if (len <= 0) return 0; + /* The new BookE ptrace interface tells if there are alignment restrictions + for watchpoints in the processors. In that case, we use that information + to determine the hardcoded watchable region for watchpoints. */ + if (have_ptrace_new_debug_booke) + { + if (booke_debug_info.data_bp_alignment + && (addr + len > (addr & ~(booke_debug_info.data_bp_alignment - 1)) + + booke_debug_info.data_bp_alignment)) + return 0; + } /* addr+len must fall in the 8 byte watchable region for DABR-based - processors. DAC-based processors, like the PowerPC 440, will use + processors (i.e., server processors). Without the new BookE ptrace + interface, DAC-based processors (i.e., embedded processors) will use addresses aligned to 4-bytes due to the way the read/write flags are - passed at the moment. */ - if (((ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) - && (addr + len) > (addr & ~3) + 4) - || (addr + len) > (addr & ~7) + 8) + passed in the old ptrace interface. */ + else if (((ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) + && (addr + len) > (addr & ~3) + 4) + || (addr + len) > (addr & ~7) + 8) return 0; return 1; } -/* The cached DABR value, to install in new threads. */ -static long saved_dabr_value; +/* This function compares two ppc_hw_breakpoint structs field-by-field. */ +static inline int +booke_cmp_hw_point (struct ppc_hw_breakpoint *a, struct ppc_hw_breakpoint *b) +{ + return (a->trigger_type == b->trigger_type + && a->addr_mode == b->addr_mode + && a->condition_mode == b->condition_mode + && a->addr == b->addr + && a->addr2 == b->addr2 + && a->condition_value == b->condition_value); +} + +/* This function can be used to retrieve a thread_points by the TID of the + related process/thread. If nothing has been found, and ALLOC_NEW is 0, + it returns NULL. If ALLOC_NEW is non-zero, a new thread_points for the + provided TID will be created and returned. */ +static struct thread_points * +booke_find_thread_points_by_tid (int tid, int alloc_new) +{ + int i; + struct thread_points *t; + + for (i = 0; VEC_iterate (thread_points_p, ppc_threads, i, t); i++) + if (t->tid == tid) + return t; + + t = NULL; + + /* Do we need to allocate a new point_item + if the wanted one does not exist? */ + if (alloc_new) + { + t = xmalloc (sizeof (struct thread_points)); + t->hw_breaks = xzalloc (max_slots_number * sizeof (struct hw_break_tuple)); + t->tid = tid; + VEC_safe_push (thread_points_p, ppc_threads, t); + } + + return t; +} + +/* This function is a generic wrapper that is responsible for inserting a + *point (i.e., calling `ptrace' in order to issue the request to the + kernel) and registering it internally in GDB. */ +static void +booke_insert_point (struct ppc_hw_breakpoint *b, int tid) +{ + int i; + long slot; + struct ppc_hw_breakpoint *p = xmalloc (sizeof (struct ppc_hw_breakpoint)); + struct hw_break_tuple *hw_breaks; + struct cleanup *c = make_cleanup (xfree, p); + struct thread_points *t; + struct hw_break_tuple *tuple; + + memcpy (p, b, sizeof (struct ppc_hw_breakpoint)); + + errno = 0; + slot = ptrace (PPC_PTRACE_SETHWDEBUG, tid, 0, p); + if (slot < 0) + perror_with_name (_("Unexpected error setting breakpoint or watchpoint")); + + /* Everything went fine, so we have to register this *point. */ + t = booke_find_thread_points_by_tid (tid, 1); + gdb_assert (t != NULL); + hw_breaks = t->hw_breaks; + + /* Find a free element in the hw_breaks vector. */ + for (i = 0; i < max_slots_number; i++) + if (hw_breaks[i].hw_break == NULL) + { + hw_breaks[i].slot = slot; + hw_breaks[i].hw_break = p; + break; + } + + gdb_assert (i != max_slots_number); + + discard_cleanups (c); +} + +/* This function is a generic wrapper that is responsible for removing a + *point (i.e., calling `ptrace' in order to issue the request to the + kernel), and unregistering it internally at GDB. */ +static void +booke_remove_point (struct ppc_hw_breakpoint *b, int tid) +{ + int i; + long slot; + struct hw_break_tuple *hw_breaks; + struct thread_points *t; + + t = booke_find_thread_points_by_tid (tid, 0); + gdb_assert (t != NULL); + hw_breaks = t->hw_breaks; + + for (i = 0; i < max_slots_number; i++) + if (hw_breaks[i].hw_break && booke_cmp_hw_point (hw_breaks[i].hw_break, b)) + break; + + gdb_assert (i != max_slots_number); + + errno = 0; + if (ptrace (PPC_PTRACE_DELHWDEBUG, tid, 0, hw_breaks[i].slot) < 0) + perror_with_name (_("Unexpected error deleting breakpoint or watchpoint")); + + xfree (hw_breaks[i].hw_break); + hw_breaks[i].hw_break = NULL; +} -/* Set a watchpoint of type TYPE at address ADDR. */ static int -ppc_linux_insert_watchpoint (CORE_ADDR addr, int len, int rw) +ppc_linux_insert_hw_breakpoint (struct gdbarch *gdbarch, + struct bp_target_info *bp_tgt) { struct lwp_info *lp; ptid_t ptid; - long dabr_value; - long read_mode, write_mode; - if (ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) - { - /* PowerPC 440 requires only the read/write flags to be passed - to the kernel. */ - read_mode = 1; - write_mode = 2; - } - else - { - /* PowerPC 970 and other DABR-based processors are required to pass - the Breakpoint Translation bit together with the flags. */ - read_mode = 5; - write_mode = 6; - } - - dabr_value = addr & ~(read_mode | write_mode); - switch (rw) - { - case hw_read: - /* Set read and translate bits. */ - dabr_value |= read_mode; - break; - case hw_write: - /* Set write and translate bits. */ - dabr_value |= write_mode; - break; - case hw_access: - /* Set read, write and translate bits. */ - dabr_value |= read_mode | write_mode; - break; + if (!have_ptrace_new_debug_booke) + return -1; + + ALL_LWPS (lp, ptid) + { + struct ppc_hw_breakpoint p; + + p.version = PPC_DEBUG_CURRENT_VERSION; + p.trigger_type = PPC_BREAKPOINT_TRIGGER_EXECUTE; + p.addr_mode = PPC_BREAKPOINT_MODE_EXACT; + p.condition_mode = PPC_BREAKPOINT_CONDITION_NONE; + p.addr = (uint64_t) bp_tgt->placed_address; + p.addr2 = 0; + p.condition_value = 0; + + booke_insert_point (&p, TIDGET (ptid)); } - saved_dabr_value = dabr_value; + return 0; +} + +static int +ppc_linux_remove_hw_breakpoint (struct gdbarch *gdbarch, + struct bp_target_info *bp_tgt) +{ + struct lwp_info *lp; + ptid_t ptid; + + if (!have_ptrace_new_debug_booke) + return -1; ALL_LWPS (lp, ptid) - if (ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value) < 0) - return -1; + { + struct ppc_hw_breakpoint p; + + p.version = PPC_DEBUG_CURRENT_VERSION; + p.trigger_type = PPC_BREAKPOINT_TRIGGER_EXECUTE; + p.addr_mode = PPC_BREAKPOINT_MODE_EXACT; + p.condition_mode = PPC_BREAKPOINT_CONDITION_NONE; + p.addr = (uint64_t) bp_tgt->placed_address; + p.addr2 = 0; + p.condition_value = 0; + + booke_remove_point (&p, TIDGET (ptid)); + } return 0; } static int +get_trigger_type (int rw) +{ + int t; + + if (rw == hw_read) + t = PPC_BREAKPOINT_TRIGGER_READ; + else if (rw == hw_write) + t = PPC_BREAKPOINT_TRIGGER_WRITE; + else + t = PPC_BREAKPOINT_TRIGGER_READ | PPC_BREAKPOINT_TRIGGER_WRITE; + + return t; +} + +static int +ppc_linux_insert_watchpoint (CORE_ADDR addr, int len, int rw) +{ + struct lwp_info *lp; + ptid_t ptid; + int ret = -1; + + if (have_ptrace_new_debug_booke) + { + struct ppc_hw_breakpoint p; + + p.version = PPC_DEBUG_CURRENT_VERSION; + p.trigger_type = get_trigger_type (rw); + p.addr_mode = PPC_BREAKPOINT_MODE_EXACT; + p.condition_mode = PPC_BREAKPOINT_CONDITION_NONE; + p.addr = (uint64_t) addr; + p.addr2 = 0; + p.condition_value = 0; + + ALL_LWPS (lp, ptid) + booke_insert_point (&p, TIDGET (ptid)); + + ret = 0; + } + else + { + long dabr_value; + long read_mode, write_mode; + + if (ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) + { + /* PowerPC 440 requires only the read/write flags to be passed + to the kernel. */ + read_mode = 1; + write_mode = 2; + } + else + { + /* PowerPC 970 and other DABR-based processors are required to pass + the Breakpoint Translation bit together with the flags. */ + read_mode = 5; + write_mode = 6; + } + + dabr_value = addr & ~(read_mode | write_mode); + switch (rw) + { + case hw_read: + /* Set read and translate bits. */ + dabr_value |= read_mode; + break; + case hw_write: + /* Set write and translate bits. */ + dabr_value |= write_mode; + break; + case hw_access: + /* Set read, write and translate bits. */ + dabr_value |= read_mode | write_mode; + break; + } + + saved_dabr_value = dabr_value; + + ALL_LWPS (lp, ptid) + if (ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value) < 0) + return -1; + + ret = 0; + } + + return ret; +} + +static int ppc_linux_remove_watchpoint (CORE_ADDR addr, int len, int rw) { struct lwp_info *lp; ptid_t ptid; - long dabr_value = 0; + int ret = -1; - saved_dabr_value = 0; - ALL_LWPS (lp, ptid) - if (ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value) < 0) - return -1; - return 0; + if (have_ptrace_new_debug_booke) + { + struct ppc_hw_breakpoint p; + + p.version = PPC_DEBUG_CURRENT_VERSION; + p.trigger_type = get_trigger_type (rw); + p.addr_mode = PPC_BREAKPOINT_MODE_EXACT; + p.condition_mode = PPC_BREAKPOINT_CONDITION_NONE; + p.addr = (uint64_t) addr; + p.addr2 = 0; + p.condition_value = 0; + + ALL_LWPS (lp, ptid) + booke_remove_point (&p, TIDGET (ptid)); + + ret = 0; + } + else + { + saved_dabr_value = 0; + ALL_LWPS (lp, ptid) + if (ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value) < 0) + return -1; + + ret = 0; + } + + return ret; } static void ppc_linux_new_thread (ptid_t ptid) { - ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value); + int tid = TIDGET (ptid); + + if (have_ptrace_new_debug_booke) + { + int i; + struct thread_points *p; + struct hw_break_tuple *hw_breaks; + + /* Get a list of breakpoints from any thread. */ + p = VEC_last (thread_points_p, ppc_threads); + hw_breaks = p->hw_breaks; + + /* Copy that thread's breakpoints and watchpoints to the new thread. */ + for (i = 0; i < max_slots_number; i++) + if (hw_breaks[i].hw_break) + booke_insert_point (hw_breaks[i].hw_break, tid); + } + else + ptrace (PTRACE_SET_DEBUGREG, tid, 0, saved_dabr_value); } static int @@ -1408,6 +1802,29 @@ || (siginfo_p->si_code & 0xffff) != 0x0004 /* TRAP_HWBKPT */) return 0; + if (have_ptrace_new_debug_booke) + { + int i; + struct thread_points *t; + struct hw_break_tuple *hw_breaks; + /* The index (or slot) of the *point is passed in the si_errno field. */ + int slot = siginfo_p->si_errno; + + t = booke_find_thread_points_by_tid (TIDGET (inferior_ptid), 0); + + /* Find out if this *point is a hardware breakpoint. + If so, we should return 0. */ + if (t) + { + hw_breaks = t->hw_breaks; + for (i = 0; i < max_slots_number; i++) + if (hw_breaks[i].hw_break && hw_breaks[i].slot == slot + && hw_breaks[i].hw_break->trigger_type + == PPC_BREAKPOINT_TRIGGER_EXECUTE) + return 0; + } + } + *addr_p = (CORE_ADDR) (uintptr_t) siginfo_p->si_addr; return 1; } @@ -1426,7 +1843,10 @@ { int mask; - if (ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) + if (have_ptrace_new_debug_booke + && ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) + return start <= addr && start + length >= addr; + else if (ppc_linux_get_hwcap () & PPC_FEATURE_BOOKE) mask = 3; else mask = 7; @@ -1595,6 +2015,20 @@ perror_with_name (_("Unable to fetch AltiVec registers")); } + /* Check for kernel support for new BOOKE debugging registers. */ + if (ptrace (PPC_PTRACE_GETHWDBGINFO, tid, 0, &booke_debug_info) >= 0) + { + have_ptrace_new_debug_booke = 1; + max_slots_number = booke_debug_info.num_instruction_bps + + booke_debug_info.num_data_bps + booke_debug_info.num_condition_regs; + } + else + { + /* Old school interface and no new BOOKE registers support. */ + have_ptrace_new_debug_booke = 0; + memset (&booke_debug_info, 0, sizeof (struct ppc_debug_info)); + } + /* Power ISA 2.05 (implemented by Power 6 and newer processors) increases the FPSCR from 32 bits to 64 bits. Even though Power 7 supports this ISA version, it doesn't have PPC_FEATURE_ARCH_2_05 set, only @@ -1643,8 +2077,10 @@ t->to_fetch_registers = ppc_linux_fetch_inferior_registers; t->to_store_registers = ppc_linux_store_inferior_registers; - /* Add our watchpoint methods. */ - t->to_can_use_hw_breakpoint = ppc_linux_check_watch_resources; + /* Add our breakpoint/watchpoint methods. */ + t->to_can_use_hw_breakpoint = ppc_linux_can_use_hw_breakpoint; + t->to_insert_hw_breakpoint = ppc_linux_insert_hw_breakpoint; + t->to_remove_hw_breakpoint = ppc_linux_remove_hw_breakpoint; t->to_region_ok_for_hw_watchpoint = ppc_linux_region_ok_for_hw_watchpoint; t->to_insert_watchpoint = ppc_linux_insert_watchpoint; t->to_remove_watchpoint = ppc_linux_remove_watchpoint; --=-u6zmNzt1Zjf/fx1bo/+s--