Patch updated with the fixes. Regards, Luis > Still looks good to me :). Just a couple of nits, but otherwise approved. > It would still be nice if Ulrich had a chance to take a quick look ;-). > > > +struct ppc_debug_info { > > + uint32_t version; /* Only version 1 exists to date */ > > The curly brace should be at the beginning of the next line. > And the indentation (probably a copy-paste from the kernel headers?) > needs to be adjusted. > > Not that it really matters a whole lot. For this section, if it makes > things simpler to preserve the indentation of the original, I could > be convinced to leave the code untouched. > > > +static int get_trigger_type (int rw) > > Formatting nit as well: > > static int > get_trigger_type (int rw) >