From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aRMcDjWkb2m5xAwAWB0awg (envelope-from ) for ; Tue, 20 Jan 2026 10:50:13 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=QHA9lZd1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 352901E0AD; Tue, 20 Jan 2026 10:50:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BDFA91E08D for ; Tue, 20 Jan 2026 10:50:11 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4C5EC4BBCDF0 for ; Tue, 20 Jan 2026 15:50:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C5EC4BBCDF0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=QHA9lZd1 Received: from sonic310-11.consmr.mail.ir2.yahoo.com (sonic310-11.consmr.mail.ir2.yahoo.com [77.238.177.32]) by sourceware.org (Postfix) with ESMTPS id 22E794BA9003 for ; Tue, 20 Jan 2026 15:49:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22E794BA9003 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 22E794BA9003 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.177.32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768924173; cv=none; b=N6VxpKPYINQ5xUM28o32bm8zjExJEOkoF7XjLT4wzohTW3Dc98nudfWrzCNUAbqE03EltjnQa1fsPXTpbuDVfDUUEdhfUJ1WviBiieqcNYv8AQzj6cmt5LMKtOErOguTKe8gzvKufKoagxzjP8h44n1n8raGqHrooq2AkJdUELg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768924173; c=relaxed/simple; bh=ihja9jlk0Iy8Y7UnD+j6IwNwPLum1u+dGJGqOiBmlIk=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=qZucPP1dbQCh2mLKRwBr4T9UPpGnZeCOxV7NTcCHAaeTRDh3nDIobw41SpYKRnxPwp5gRbZ1CdVK1a03eXkJLxcb+FkCMDYeKpf3FgBQKFRixtOf/7SG5y+GCPItwuKy3ex9khNrujWqzsa2Fj63JQm8w3LQnJczSQkqaeOk/qE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 22E794BA9003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1768924172; bh=ihja9jlk0Iy8Y7UnD+j6IwNwPLum1u+dGJGqOiBmlIk=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=QHA9lZd1sRuRH43oz/ylpEt+4dilpc1qG3crwhNlT8aTOhek3TJE5opcYitVvfaWb3sJwnq7gOZ+A6ZHAI8J5/PvI4p9QIWWOWRCgT8EEAG6kU9rKvVFIknoDZzynZsr9MblidH+z05unCJOAKxJ+JxNzk0DPQr5CQFPx+QO+lLLkAwkcm1UrbgCmYoC3s2/S/VjXiiK8cYyln9jm/DetOOUf5GjVVGPGeriuvKBvrlFSRlcVa6T6MQfa0pVyKnu6hbcnsXrr8H5thIRGFaIs5OR5ACbijrsZXNxrTfEcnT4rPryC3m2GTJbPYLjX/es6Eaa1BjXz9kNhAZXx2ILYg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1768924172; bh=oHz9+WC1M4FBlRtvT4ZF5weDf8AE5zrkjKNAv7Vb1hZ=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=EL/Nqp4lwMNipz9CCqDRgJsF8ZJnA3UACZX5BH+NBXcedvTafwc/pZ294U2wpwgBorKFNboF4EvCKxGPz8hZ8mzyvG7RKNwJxZI050yvaY1adu0CizpPzXH5OUw+ADq+qNXaUnTiVExF5rX30kJLktyB0qzfiole1D+b/Esp7tSG8f5E1/tsM9gPwzCefbDIYecNpVpaQjDZh7cGe27D/lowN/FPuuMzHfMavAWD724U3A8mWAj8HyzzQPJ2C8DY6Z86bteRfwiV3xNdWvL+xj4uB64S6EzYgBpk/btxtv4Jt2e0V+o5JRkD7A4MJajt7Yc7h53hi9LGEwYmj2glTg== X-YMail-OSG: uJctI0cVM1nERprMt56k4qu1YkxY3t3rcmOnF.ARsfVHqEp_nFFVRMydt.5s9_7 nCFG9Tfj37AT.nmAuvU.kfgYcQft_vpKW7Pw01QO6Wtb3LGNTsj7No3qfQEmYmDZtqVWwciGPn.1 fmk7Ky19QakuVMM3RWUucZdAC2sJzxsWzgcMt7e8CEQCq7QQcn5THWguFQA9QL5Qf7WF0d4gMrPp YOtvskyl9vx51SPNyS7gup3eH4TgzQCLSQxlodSEaNwfsytnxiLUH.jF1r32IdlcdDx7zLC_tkXI BegLwYMChQLXSopD9AdOEG5b.Gx99Dzak7aFoPDIEdFtkMwg1i8d5c4GObMwSkphbdz4KUPkn9NZ iKvpw4W9OmX1aZrJJtXNQ32rfsVnmPcHLVfAiEAqMny7SfrgNzu8y21yAfo6_9UVwjukOxPWInhM aIsfhhEKVIoEB7saSPTDZlHW3HsZop.nf0LR5s4IiYE8paNua6a5gP5mzHWSTRIJi6wret.aVRFr RYyhE4_BPeQTEFbLOKFe3IZVJ_0KjhMG76xh.iKmbun5pn6lzpYyT_MJdtjTJu1tEGXQk9a1TndD VR8VLrwHx_5g4jC8eQWzm0MXXUoIC7QmH3z8Bsn8BSsyUbD.4sXS8ENN.0.jwLfo_zSuRNi5M2DA 49r_8IAgbJjTFCN9LwH5C3PRGR8QlXTuUj52xgK_pPl1yjLi5lW2vWh.usH1D3Af7fj2zyZ4EyWj suwZcsuVInaj3WbbnuVBDrKamGTaYqvvMiA.Ay3E2Y8Oeju5qZni8AqoHof.wfPRqMzku5g7Ffce Kl75tWxR8nv9ue.Iyh_8myiKRy9nwaEfnU_vStyTQANsgchZwGCvbuYYZZt4ddDruCWCDwQ_xcHy XBEsZiivhNZO5BS3XGMpmqnM1PjzRzrh8.fP6PNmPdtfemimfQ2yJv0pxozXPJIVghIfnMkKzGbT E7.4pYNTcK0634C4nHZa3GJBl4Bz5L9Vgtd4G8Tuftp9f3vPaxVqNiqMMHVgtvu_7hALNXt671N. Kkfq3DKbRavxS8bePqOjDWTcP8aIb34xLvBNYqUdQD2lS76_jetYFTO0gEB1dV_mgEOOWJASFeZn oV1735yOMqF0uCwW53hS1w9hEw3_tCXymCv6mrGgwTELdx5YPwvWm1RJR9t80Tty1NHULVLbE.bl KDoDHCSLXFrsITf7LyijFo94PEuVKiSmKt0XpkRlFPhvJ65M.134JZr_CEYzR.bu09J6SM0TkYEQ uvvLIwdKKUT856m5gb0anbLSCbNv7frluzph2DAqmeG7xwDyenPkdq.tF89bJAmBcmtUoq7RzweD x69ExL30Bey_.y3uBowosAtIpaBedtSEEXRMtqLi68D0yF8ZIS6p16fR3ERclwgPDS8DlYfwGz97 9xYiTR8wgRwlzNWKej2oZl3qJ.G9PM2CbdvFQj0o0Fr9GFx0o1.lP.hIU0mwGsxU4hrqctPEMcpk QiQb.jymuPFMeznfzwdMP1B.bf2bupqr5yRPY8tf93zdby7xSjQhZSuQt0qQZE8jnjurG6crSRPH NRd5ywoqbWQFozZ0K1nojilDrOxLy9WrF3PyGlcZpA1uuKNv3Q.68zBE0kHXJgXBxMqDU9XmVBmV ZxYS_slIl_3Azi90R6RVJbpybw61M4gV61mTfWPBVhkIjUYi4SBn6q_ZeGJ8VUBZy32Fd_jk2a7I JoomJ8U3dh5YqLL83BlbFqCZgPZ7KqaFAN2NSPhrBonxHNMprCHcfjPqQRZsdxQ2OB16aeljvc7D Hv8gkQL4ksZElFr_s6_A9ZNxSvhcGg0ty_neTNyHTIZqiHjSL1CkqhUNmdJvQFkn3LuuG2oV6MS8 PPDiXfXC8CoYq50CsRM3HkIP9p2YTwAEm2Jc0FxDTrYw.9LM_ubdrEfNpM.1j7j6Lew5ADAF3mqY oRbUPrQFQHymMNiOFy_qBCo1OqkUHDXi6XQq98Yc8GxG_nYGazSTXnupvBBUyiKcOo_FbfP7wDdS KbLsEmNGBZsB4.GuGCjcqeZiDwIvl6IlWnof4lZHYIkxxTDh1C2YPTkbcLi0zXdj1K8qgaPbf0wv AlMUeMvccWZOgX320JfPU4s75xcA_M3eX2lV7staU472DM4apSGfpEh4aHMP0zBj1uChv62ZfilK 5wTJnCJhusZfx8b57Rpb4iuP7bxdZWUB2lrUaqk4z1FwSSH1mcwZAMXEqgO7XGHVO0v6ke5NHQFi MHe6rpD4yui7oym_8KB0G7YWsLHs7gUsHQ7rYx7szFPB.TwXwcLljyw-- X-Sonic-MF: X-Sonic-ID: c3baeb81-b085-4785-9038-ee621f95781d Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Tue, 20 Jan 2026 15:49:32 +0000 Date: Tue, 20 Jan 2026 15:49:30 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" , "Schimpe, Christina" , Tom Tromey Message-ID: <125527138.4011190.1768924170236@mail.yahoo.com> In-Reply-To: References: <20260117134052.2660009-1-ssbssa@yahoo.de> <20260117134052.2660009-5-ssbssa@yahoo.de> Subject: Re: [PATCH v2 05/11] Move x86 debug registers and related code into x86-windows-nat.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.24987 YMailNorrin X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Am Montag, 19. Januar 2026 um 13:49:30 MEZ hat Schimpe, Christina Folgendes geschrieben: > > --- a/gdb/x86-windows-nat.c > > +++ b/gdb/x86-windows-nat.c > > @@ -18,22 +18,213 @@ > >=C2=A0 =C2=A0 along with this program.=C2=A0 If not, see .=C2=A0 */ > > > >=C2=A0 #include "windows-nat.h" > > +#include "regcache.h" > > +#include "gdbarch.h" > > > >=C2=A0 #include "x86-nat.h" > > > > +using namespace windows_nat; > > + > > +/* If we're not using the old Cygwin header file set, define the > > +=C2=A0 following which never should have been in the generic Win32 API > > +=C2=A0 headers in the first place since they were our own invention...= =C2=A0 */ > > +#ifndef _GNU_H_WINDOWS_H enum > > +=C2=A0 { > > +=C2=A0 =C2=A0 FLAG_TRACE_BIT =3D 0x100, > > +=C2=A0 }; > > +#endif > > + > > +#define DR6_CLEAR_VALUE 0xffff0ff0 > > + > > +#define CHECK(x)=C2=A0 =C2=A0 check (x, __FILE__,__LINE__) > > + > > +static void > > +check (BOOL ok, const char *file, int line) { >=C2=A0 > Isn't the exact same function also available in windows-nat.c ? > Shouldn't we better share the code? You're right, I forgot that I copied that function, I wonder if I should make it a (static) windows_nat_target member. And should I move the CHECK define to windows-nat.h as well? Hannes