Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support

Tom Tromey
2011-05-19T19:27:09Z

>>>>> "Jiang" == Jiang Jilin <freephp@gmail.com> writes:

I'm sorry you haven't gotten a reply to this.

Jiang> 2011-03-29 Jiang Jilin <freephp@gmail.com>
Jiang> * i386-tdep.c (i386_process_record): Rewrite the codes for
Jiang> opcode 0x0f01 and add more instructions support.

I am not the right person to review this.
I would have to look up all this stuff in the x86 references to try to
understand it. I'd appreciate it if Hui would reply about these details.
Most of the code seems to at least be in the same style as the
surrounding code, so at least on those grounds I find it basically ok.

Jiang> + switch (reg_rm)
Jiang> + {
Jiang> + /* vmcall */
Jiang> + case 0x01:

It looks like there is an extra space in the indentation here.

Jiang> + q = yquery (_("\
Jiang> + Process record ignores the memory change of \
Jiang> + instruction at address %s\n\
Jiang> + because it can't get the value of the segment \
Jiang> + register.\n Do you want to stop the program?"),

Reformatting this message like this is not ok.
The way it was before the patch is more correct.

Tom