Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support

Jiang Jilin
2010-09-16T14:41:08Z

Hi,

I'm very sorry due to my work, however, it's good news that the I've
finished the paper assignment.

Should I rewrite the patch again? Any comments are welcome!

Thank you!

On Mon, Oct 12, 2009 at 10:21 AM, Jiang Jilin <freephp@gmail.com> wrote:
> On Mon, Oct 12, 2009 at 10:04 AM, Michael Snyder <msnyder@vmware.com> wrote:
>> Jiang Jilin wrote:
>>>
>>> Hi, guys
>>>
>>> I've rewrite the codes for opcode 0x0f01 with more readable, add
>>> xgetbv/xsetbv/rdtscp/vmcall/vmlaunch/vmresume/vmxoff instructions
>>> support as well.
>>>
>>> However, I'm *not* sure it's whether right or not, especially with
>>> the new supported instructions beginning with "vm". And I remove all
>>> codes to save EFLAGS register which is not specified to be saved by
>>> Intel's manual, so please help me review them.
>>>
>>> Luckily, there is no regression when using precord.exp board file to test.
>>>
>>> At last but not least, there is some differences in gdb.sum when
>>> 'make check' before and after applying this patch. I cannot make
>>> a decision whether it's correct, so please help me. The diff are
>>> as follows:
>>
>> Ah well, but you see, now the change is too big to be accepted
>> without a copyright assignment.  Do you want to start the process
>> of filing one?
>
> I've done as Joel told me, now I just wait for the paper arrival.
>
> Anyway, thank you! :)
>
>> [Cc: Tom Tromey]
>>
> --
> Jiang
>

--
Jiang