Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support

Yao Qi
2011-03-29T11:11:12Z

On 03/29/2011 06:11 PM, Jiang Jilin wrote:

I am not the people to approve this patch. Some comments on code format
and indent.

> 2011-03-29 Jiang Jilin <freephp@gmail.com>

There should be a newline here. Please reference other changelog entries.
> * i386-tdep.c (i386_process_record): Rewrite the codes for
> opcode 0x0f01 and add more instructions support

> + switch (reg_rm)
> + {
> + /* vmcall */
> + case 0x01:
> + /* vmlaunch */
Looks like there are two extra spaces in front of your comment. Please
remove them. There are several instances of this problem in your patch.

> +
> + /* We have to store at least (4 + 2 = 6) bytes,
> + or (8 + 2 = 10) bytes at most. */

According to my limited English knowledge, it should be "6 bytes at
least *and* 10 bytes at most".

> + if (i386_record_lea_modrm_addr (&ir, &tmpu64))
> + return -1;

--
Yao (é½å°§)