From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66925 invoked by alias); 23 Dec 2019 00:19:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66911 invoked by uid 89); 23 Dec 2019 00:19:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=folgendes, hat, HX-Languages-Length:1750, dezember X-HELO: sonic311-32.consmr.mail.ir2.yahoo.com Received: from sonic311-32.consmr.mail.ir2.yahoo.com (HELO sonic311-32.consmr.mail.ir2.yahoo.com) (77.238.176.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Dec 2019 00:19:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1577060377; bh=zrI6r6NyhsR+fZnrN7J0Urr9x0XbynphLCzdaZsfyWg=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject; b=BbJf5vRy6amDmDGBXhFD13QIKlCygxZn1bZlaku232jI4fDcNxmCbJRKa4ZIGRc0ZxEAPu+cP4olWcmpmd6TYO3l7YsNyfK9jZL7chwc2qMDrECaxOtAeh0YVxN38/jaazPaYmY4jggmnd6s19fI4pcIV7K2Bs9SUBuzEUfczo7Wqv6BIygiunv95crHenC05hNYiqjckFU93Juo5y/p+7QmWoQExbl7TTQIuVw8aG52m6RgGbZSflCCOTMVQ0g9pPolIia3fKnmQPKv5irUozW+G1VFHLuu8ul5M4LqKqUQRCJFOEDl+xP8JPCI4/3qgLNcMc9GVTVkvqblz7TZWg== Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Mon, 23 Dec 2019 00:19:37 +0000 Date: Mon, 23 Dec 2019 00:19:00 -0000 From: "Hannes Domani via gdb-patches" Reply-To: Hannes Domani To: Gdb-patches Message-ID: <1254758183.4399923.1577060372673@mail.yahoo.com> In-Reply-To: <874kxrc3ha.fsf@tromey.com> References: <20191221153325.6961-1-ssbssa.ref@yahoo.de> <20191221153325.6961-1-ssbssa@yahoo.de> <20191222005754.GF3865@embecosm.com> <874kxrc3ha.fsf@tromey.com> Subject: Re: [RFC][PATCH] Call tui_before_prompt in do_scroll_vertical MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00960.txt.bz2 Am Montag, 23. Dezember 2019, 01:03:49 MEZ hat Tom Tromey Folgendes geschrieben: > >>>>> "Andrew" == Andrew Burgess writes: > > >> First I tried it with tui_update_source_windows_with_line, but this didn't > >> reset from_source_symtab (which was set deep in print_source_lines), > >> which resulted in some weird behavior when switching from "layout split" > >> to "layout asm" after scrolling down in the src window (the asm window > >> was then overwritten by the src window). > > I wonder if we really need to change the current source symtab. > If so, I guess the TUI could just call > set_current_source_symtab_and_line directly. > > The patch below removes the call to print_source_lines -- this approach > just seems too roundabout for my taste. > > Andrew> I was able to reproduce the layout split -> layout asm issue you > Andrew> describe, but, I'm not convinced that the solution below is the right > Andrew> way to go. > > With my patch I can't reproduce this, but I don't know whether I'm doing > it properly. > > Hannes, could you possibly try this patch? > > This could maybe be made even a bit smaller, but it's hard to be sure. > Despite all the cleanups, I find this area still pretty confusing. This fixes the scrolling, and I no longer have any problem when switching from layout split -> layout asm after scrolling the src window. But now, when in layout split, the asm window doesn't scroll along with the src window any more. I found this to be a very convenient feature, because this showed you which asm lines belonged to which src line (as good as the optimized code allowed at least). Regards Hannes Domani