Re: [PATCH 2/2] Add "set/show debug unwinder" prefix commands.

Samuel Bronson
2009-05-31T15:50:51Z

On Sat, May 30, 2009 at 3:24 PM, Doug Evans <dje@google.com> wrote:
> On Fri, May 29, 2009 at 4:16 PM, Samuel Bronson <naesten@gmail.com> wrote:
>> Also add one subcommand for tracing the sniffing of stack frames by
>> unwinders.
>>
>> [...]
>> +/* trace unwinders called */
>> +static int trace_unwinders;
>
> [N.B. None of this is binding.  Just "fwiw".]
>
> Just some nits:
>
> I don't care *too* much about the naming, but I do care about
> following existing conventions and gdb seems to have a pretty
> consistent convention of using "debug" in these situations instead of
> "trace".  E.g., debug_unwinders?

Ah. Didn't realize it made much difference for static vars.

> Adding another level of prefixes just for debugging the unwinder seems
> excessive.

Well, I had been planning to add another subcommand to trace the
activities of the dawrf2 unwinder. I did start it, but then I
discovered that the CFI for the code I was wondering about was being
left out of the kernel image due to an incorrect linker script. I
still think it might be useful to be able to add others, but I'm not
going to be stubborn about it.