From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3780 invoked by alias); 29 Apr 2009 02:16:19 -0000 Received: (qmail 3772 invoked by uid 22791); 29 Apr 2009 02:16:18 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DATE_IN_PAST_03_06 X-Spam-Check-By: sourceware.org Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Apr 2009 02:16:13 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp05.br.ibm.com (8.13.1/8.13.1) with ESMTP id n3T2Axq7017329 for ; Tue, 28 Apr 2009 23:10:59 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3T2GVvn1982610 for ; Tue, 28 Apr 2009 23:16:31 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3T2G86D022114 for ; Tue, 28 Apr 2009 23:16:08 -0300 Received: from [9.18.199.215] ([9.18.199.215]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3T2G7TE022107; Tue, 28 Apr 2009 23:16:07 -0300 Subject: Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Joel Brobecker Cc: luisgpm@linux.vnet.ibm.com, gdb-patches@sourceware.org, Mark Kettenis In-Reply-To: <20090428200725.GC31821@adacore.com> References: <1223404355.7030.20.camel@miki> <1224184035.27672.64.camel@miki> <1231289020.2026.3.camel@miki> <200901070955.n079twBj014790@brahms.sibelius.xs4all.nl> <1231344540.2026.7.camel@miki> <1231436749.2026.19.camel@miki> <1231503988.12849.6.camel@gargoyle> <1232558849.6328.23.camel@miki> <20090428200725.GC31821@adacore.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Wed, 29 Apr 2009 02:16:00 -0000 Message-Id: <1240953172.2392.1.camel@miki> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00777.txt.bz2 Hi Joel, On Tue, 2009-04-28 at 13:07 -0700, Joel Brobecker wrote: > Sergio, > > > 2009-01-21 Sergio Durigan Junior > > > > * ppc-linux-nat.c (have_ptrace_getsetregs): New variable. > > (have_ptrace_getsetfpregs): Likewise. > > fetch_all_gp_regs): New function. > > (fetch_gp_regs): New function. > > (fetch_all_fp_regs): Likewise. > > (fetch_fp_regs): New function. > > (fetch_ppc_registers): Using the new methods to fetch general- > > purpose and floating-pointer registers. > > (store_all_gp_regs): New function. > > (store_gp_regs): Likewise. > > (store_all_fp_regs): New function. > > (store_fp_regs): Likewise. > > (store_ppc_registers): Using the new methods to store general- > > purpose and floating-pointer registers. > > Sorry for the delay in reviewing this. I don't know much about ptrace > except as a user, but this seems to make sense. The only request I have > is for you to write a small comment describing each new function you > introduce. The patch is OK with those changes. So the request is about the ChangeLog, right? Ok, I'll resubmit it with the modifications as soon as possible. > PS: I assume you tested the change on 2 systems, one with the > functionality, and one without? Yes, I did :-). Thanks, -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil