Hi Eli, On Sat, 2009-04-25 at 11:48 +0300, Eli Zaretskii wrote: > > From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= > > Date: Wed, 22 Apr 2009 21:33:03 -0300 > > > > gdb/ChangeLog: > > > > 2009-04-22 Sergio Durigan Junior > > > > * syscalls/gdb-syscalls.dtd: New definition file for syscall's XML > > support. > > * syscalls/i386-syscalls.xml: New file for i386 syscalls. > > * syscalls/ppc-syscalls.xml: New file for PPC syscalls. > > * syscalls/ppc64-syscalls.xml: New file for PPC64 syscalls. > > The last 3 entries name the files incorrectly, and also do not say > that the lists are for GNU/Linux systems that use these hardware > architectures. Ops, sorry. I didn't notice that it was wrong, it's an old version of the ChangeLog. > > diff --git a/gdb/syscalls/i386-linux.xml b/gdb/syscalls/i386-linux.xml > > new file mode 100644 > > index 0000000..6f2beee > > --- /dev/null > > +++ b/gdb/syscalls/i386-linux.xml > > @@ -0,0 +1,334 @@ > > + > > + > > + > > + > > + > > + > > + > > Where does this information come from? If there's some system file > from which you gleaned this, I'd suggest to name it here. This is so > someone in the future could update this database per the OS > development. Oh, sure. Here goes a refreshed version of the patch containing the changes. I'll address the other comments (in the other patches) later today. Thank you, -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil gdb/ChangeLog: 2009-04-25 Sergio Durigan Junior * syscalls/gdb-syscalls.dtd: New definition file for syscall's XML support. * syscalls/i386-linux.xml: New file containing information about syscalls for GNU/Linux systems that use i386 architecture. * syscalls/ppc-linux.xml: New file containing information about syscalls for GNU/Linux systems that use PPC architecture. * syscalls/ppc64-linux.xml: New file containing information about syscalls for GNU/Linux systems that use PPC64 architecture. * xml-syscall.c: New file containing functions for manipulating syscall's XML files. * xml-syscall.h: New file, exporting the functions above mentioned.