Re: [PATCH 0/3] catch syscall -- try 5 -- Introduction

Eli Zaretskii
2009-04-24T13:47:18Z

> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 23 Apr 2009 15:26:57 -0600
>
> + add_setshow_filename_cmd ("data-directory", class_maintenance,
> + &gdb_datadir, _("Set GDB's data directory."),
> + _("Show GDB's data directory."),
> + _("\
> +When set, GDB uses the specified path to search for data files."),
> + NULL, NULL,
> + &setlist,
> + &showlist);
> }

I would suggest to add another sentence with a few examples of which
data files will be looked up in that directory. Also, since this is a
directory (as opposed to a search path), let's not use "path" in the
doc string.

> +* Data Files:: GDB data files

This section is not about data files, it's about where GDB finds them.
So I suggest to change the text to the right of the menu item to
"Where @value{GDBN} looks for its data files."

> +@section GDB Data Files
^^^
"@value{GDBN}"

> +@cindex prefix for data files
> +@value{GDBN} will sometimes read an auxiliary data file. These files
> +are kept in a directory known as the @dfn{data directory}.

As in the doc string (and for the manual this is even more important),
I think we should tell here what files are looked up there.

Otherwise, the patch for the manual is fine.

Thanks.