From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3864 invoked by alias); 9 Apr 2009 19:29:46 -0000 Received: (qmail 3854 invoked by uid 22791); 9 Apr 2009 19:29:45 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Apr 2009 19:29:39 +0000 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp01.br.ibm.com (8.13.1/8.13.1) with ESMTP id n39JhVBW019702 for ; Thu, 9 Apr 2009 16:43:31 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n39JTt441589328 for ; Thu, 9 Apr 2009 16:29:55 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n39JTZvC002178 for ; Thu, 9 Apr 2009 16:29:35 -0300 Received: from [9.8.7.2] ([9.8.7.2]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n39JTY9W002160; Thu, 9 Apr 2009 16:29:34 -0300 Subject: Re: [PATCH 1/4] catch syscall -- try 4 -- Architecture-independent part From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Daniel Jacobowitz Cc: Pedro Alves , gdb-patches@sourceware.org In-Reply-To: <20090331154452.GA13260@caradoc.them.org> References: <1232929831.26873.22.camel@miki> <200901260053.06295.pedro@codesourcery.com> <1232945747.26873.27.camel@miki> <1232989355.26873.39.camel@miki> <20090201193306.GJ4597@caradoc.them.org> <1235561189.14363.20.camel@miki> <20090227221133.GA12904@caradoc.them.org> <1238352626.23609.14.camel@miki> <20090331154452.GA13260@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1 Date: Thu, 09 Apr 2009 19:29:00 -0000 Message-Id: <1239305373.6452.13.camel@miki> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00185.txt.bz2 Hi Daniel, On Tue, 2009-03-31 at 11:44 -0400, Daniel Jacobowitz wrote: > On Sun, Mar 29, 2009 at 03:50:26PM -0300, Sérgio Durigan Júnior wrote: > > ~"Catchpoint 1 (call to syscall 'chroot'), 0xffffe424 in > > __kernel_vsyscall ()\n" > > ~"0xffffe424 <__kernel_vsyscall+16>:\tpop %ebp\n" > > *stopped,frame={addr="0xffffe424",func="__kernel_vsyscall",args=[]},thread-id="1",stopped-threads="all" > > > So, what do you think of it? Analyzing it, I think it's not so useful > > except for the (obvious) part ~"Catchpoint 1 ...". > > Right. There ought to be a new reason="..." entry; search for > EXEC_ASYNC_BREAKPOINT_HIT. There should probably be some semantic > fields, too, like "old" for watchpoints. I'm sorry about taking so long to reply your messages, but I'm really busy with other things here. By the way, that's one of the reasons why I'm asking this... Well, I perfectly understand when you (or anyone else here in GDB) ask me to implement something else in the catch syscall patch, after all it's important to have a good code in GDB's codebase. But honestly, this time I think you're exaggerating a little. I know that it would be cool to have the MI support in the catch syscall feature, and I myself plan to implement this support in a future not so distant; however, and specially because I'm very busy these days, I won't be able to dedicate enough time in order to get it ready for GDB 7.0, and IMHO the catch syscall would be a *nice* feature to have in this release. So this is my opinion about this: I have the complete catch syscall patch here (the only thing that's missing is the MI support), so what do you think if we just push this patch upstream as-is (which is: in a pretty good shape, as far as I understood the others developers' -- including yours -- comments), and postpone this MI support? I think I should be able to sit down and implement this support until the end of this semester, is it good for you? Well, thanks for your time, for your valuable reviews about my code, and for your patience. Please consider my proposal and let me know what you think about it. Regards, -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil