From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8979 invoked by alias); 11 Mar 2009 20:23:44 -0000 Received: (qmail 8966 invoked by uid 22791); 11 Mar 2009 20:23:43 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e24smtp02.br.ibm.com (HELO e24smtp02.br.ibm.com) (32.104.18.86) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Mar 2009 20:23:37 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp02.br.ibm.com (8.13.1/8.13.1) with ESMTP id n2BKaN1X018333 for ; Wed, 11 Mar 2009 17:36:23 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n2BKNpRA1998870 for ; Wed, 11 Mar 2009 17:23:51 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n2BKNWM8015025 for ; Wed, 11 Mar 2009 17:23:33 -0300 Received: from [9.18.198.63] ([9.18.198.63]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n2BKNWf7015014; Wed, 11 Mar 2009 17:23:32 -0300 Subject: Re: [PATCH] PR exp/9103 From: Thiago Jung Bauermann To: Andre Oliveira Loureiro do Baixo Cc: tromey@redhat.com, gdb-patches@sourceware.org In-Reply-To: References: <20090311153711.GA5197@caradoc.them.org> Content-Type: text/plain; charset=utf-8 Date: Wed, 11 Mar 2009 20:29:00 -0000 Message-Id: <1236803010.11106.50.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00159.txt.bz2 (slightly edited to correct top-posting) El mié, 11-03-2009 a las 14:13 -0300, Andre Oliveira Loureiro do Baixo escribió: > On Wed, Mar 11, 2009 at 2:08 PM, Tom Tromey wrote: > >>>>>> "Andre" == Andre Oliveira Loureiro do Baixo writes: > > > > Andre> The patch works correctly because the function inside the modified > > Andre> condition (val_print_string) scans the string using the size of each > > Andre> character of the string. This size is passed to the function using the > > Andre> parameter TYPE_LENGTH (elttype). Char * strings are printed by this > > Andre> function, the only difference is that wchar_t* strings didn't get > > Andre> inside the condition, and now they do. > > > > Yeah, but it isn't as useful as it could be, because it doesn't > > properly handle charset conversions. Also, I suspect it won't work in > > C, where wchar_t is a typedef. > > > > Try this patch instead: > > > > http://sourceware.org/ml/gdb-patches/2009-01/msg00533.html > > Yes, it works in C with no problems at all. Tromey, do you think your charset branch will make it in time for 7.0? If not, we could consider Andre's approach... -- []'s Thiago Jung Bauermann IBM Linux Technology Center