From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30097 invoked by alias); 24 Nov 2008 22:11:00 -0000 Received: (qmail 30056 invoked by uid 22791); 24 Nov 2008 22:11:00 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 22:10:16 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw2.br.ibm.com (Postfix) with ESMTP id 9173F17F58A for ; Mon, 24 Nov 2008 18:53:55 -0200 (BRDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAON9f4W3448838 for ; Mon, 24 Nov 2008 20:09:41 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAOMA5PW004039 for ; Mon, 24 Nov 2008 20:10:06 -0200 Received: from [9.8.7.183] ([9.8.7.183]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mAOMA5xe004033; Mon, 24 Nov 2008 20:10:05 -0200 Subject: Re: [RFA] Add la_getstr member to language_defn From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches ml In-Reply-To: References: <1227417278.28256.183.camel@localhost.localdomain> <1227552637.28256.231.camel@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Date: Tue, 25 Nov 2008 11:27:00 -0000 Message-Id: <1227564607.28256.250.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00673.txt.bz2 El lun, 24-11-2008 a las 13:10 -0700, Tom Tromey escribió: > >>>>> "Thiago" == Thiago Jung Bauermann writes: > > Thiago> I was just following the la_printstr/LA_PRINT_STRING example. > Thiago> I agree la_get_string is better. Since there doesn't seem to > Thiago> be a strict pattern for these names, I'll make the change. > > Oh, I didn't realize there were already discrepancies. Sorry about that. No problem. I renamed the function. > Thiago> I'm fine with that. What about adding a const char **encoding argument? > Thiago> c_getstr could return the value from target_charset. > > Sounds reasonable to me. It is present in the version of the patch I just sent. -- []'s Thiago Jung Bauermann IBM Linux Technology Center