From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21845 invoked by alias); 18 Nov 2008 21:44:09 -0000 Received: (qmail 21833 invoked by uid 22791); 18 Nov 2008 21:44:08 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 21:43:20 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw3.br.ibm.com (Postfix) with ESMTP id 017E43901AA for ; Tue, 18 Nov 2008 19:41:01 -0200 (BRDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAIMgrV41671400 for ; Tue, 18 Nov 2008 19:42:53 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAILhGjn003210 for ; Tue, 18 Nov 2008 19:43:17 -0200 Received: from [9.8.13.78] ([9.8.13.78]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mAILhG9O003156; Tue, 18 Nov 2008 19:43:16 -0200 Subject: Re: [PATCH 4/4] catch syscall -- try 3 -- Build system, documentation and testcase From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Eli Zaretskii Cc: gdb-patches@sourceware.org In-Reply-To: References: <1226987134.5454.37.camel@miki> Content-Type: text/plain; charset=iso-8859-1 Date: Wed, 19 Nov 2008 12:49:00 -0000 Message-Id: <1227044596.5454.47.camel@miki> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00486.txt.bz2 Hi Eli, On Tue, 2008-11-18 at 22:02 +0200, Eli Zaretskii wrote: > > From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= > > Date: Tue, 18 Nov 2008 03:45:34 -0200 > > > > +if @var{GDBN} does not fully support your system's list of system > ^^^^^^^^^^ > @value{GDBN} Sorry, I'll have that fixed. > > > +(gdb) catch syscall > > +Catchpoint 1 (syscall) > > That's a strange wording. Wouldn't it be better to say > > Catchpoint 1 (any syscall) > > ? Yeah, I think you're right. > Also, please use (@value{GDBP}) (P, not N) instead of a literal (gdb), > when you show a prompt. OK. > > +Catchpoint 1 (calling syscall 'close'), 0xffffe424 in __kernel_vsyscall () > > I'd prefer > > Catchpoint 1 (call to syscall 'close') Right, but can I ask you why? :-) > > +(gdb) catch syscall chroot > > +Catchpoint 1 (syscalls 'chroot') > > "syscalls 'chroot'" (in plural) or "syscall 'chroot'" (single)? Yes, it's single. I'll fix. :-) > > +(gdb) catch syscall 252 > > +Catchpoint 1 (syscalls 'exit_group') > > The translation to a mnemonic name will only happen if the XML file > does know about the syscall, right? What if it doesn't? You mean that I should mention what would happen in this case? I think that's already mentioned, am I wrong? > Otherwise, the doco patch is approved. Thank you very much. -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil