Re: [RFA] Process record and replay, 5/10

[Thiago Jung Bauermann <bauerman@br.ibm.com>]

El jue, 06-11-2008 a las 15:48 +0800, teawater escribió:
> +/* Record the values of the registers and memory that will be changed in
> +   current system call.
> +   Return -1 if something wrong.  */
> +
> +int
> +record_linux_system_call (int num, linux_record_tdep_t * tdep)
> +{
> +  uint32_t tmpu32;
> +
> +  switch (num)
> +    {
<snip>
> +      /* sys_read */
> +    case 3:
> +      {
> +	uint32_t addr, count;
> +	regcache_raw_read (record_regcache, tdep->arg2, (gdb_byte *) & addr);
> +	regcache_raw_read (record_regcache, tdep->arg3, (gdb_byte *) & count);
> +	if (record_arch_list_add_mem (addr, count))
> +	  {
> +	    return (-1);
> +	  }
> +      }
> +      break;
<snip>
> +    case 84:
> +      regcache_raw_read (record_regcache, tdep->arg2, (gdb_byte *) & tmpu32);
> +      if (record_arch_list_add_mem (tmpu32, tdep->size__old_kernel_stat))
> +	{
> +	  return (-1);
> +	}
> +      break;

Syscalls have different numbers across different architectures in Linux,
so this file should be named i386-linux-record.c.

Do you know if what you need to record for a syscall in one architecture
is the same as what you need to record in the others? If so, it wouldn't
be hard to make this file general for Linux in all architectures, and
just get the syscall number mapping from the XML in the catch syscall
feature (here are we talking about it again... :-) ). Otherwise, you'll
have to rename the file, and also you can't directly call
record_linux_system_call directly from i386-linux-tdep.c like you do
now. You'd have to add a gdbarch method and reach this code through
that.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center