From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18150 invoked by alias); 4 Nov 2008 15:03:00 -0000 Received: (qmail 18026 invoked by uid 22791); 4 Nov 2008 15:02:58 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Nov 2008 15:02:12 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw3.br.ibm.com (Postfix) with ESMTP id 01AC93901F2 for ; Tue, 4 Nov 2008 13:00:40 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mA4F1mYm3944702 for ; Tue, 4 Nov 2008 12:01:48 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mA4F28Cg012147 for ; Tue, 4 Nov 2008 13:02:09 -0200 Received: from [9.8.9.146] ([9.8.9.146]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mA4F27c3012104; Tue, 4 Nov 2008 13:02:08 -0200 Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Phil Muldoon Cc: gdb-patches@sourceware.org In-Reply-To: <49100551.6010000@redhat.com> References: <1225773088.24532.56.camel@miki> <49100551.6010000@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Date: Tue, 04 Nov 2008 15:03:00 -0000 Message-Id: <1225810920.32321.5.camel@miki> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00027.txt.bz2 Hi Phil, On Tue, 2008-11-04 at 08:18 +0000, Phil Muldoon wrote: > Sérgio Durigan Júnior wrote: > > This last part modifies the build system (in order to implement the > > GDB's datadir), adds the documentation and the testcase for the new > > feature. > > > > Nice, looks great! Just some comments on tests. > > This is a forward of a comment from the archer list on the original > patch-set. On targets that do support syscall breakpoints, but there is > no xml database (like on x8664) will these tests just fail? Are they > gated to XFAIL (or however one would gracefully fail here). Oh, sorry about this. I completely forgot about our conversation. The way it is now, the patch will fail if the arch doesn't provide the XML file. You're right, I need to fix this and put an XFAIL. > My only other comment is how this would work on remote targets (i.e. > remote target is x86, but your host is PPC). To be completely honest, I still don't know the answer to this question. I'd be glad if some good soul could try to answer this, so that I can fix things if needed. Thanks for your valid comments. Regards, -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil