From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1098 invoked by alias); 2 Oct 2008 03:47:51 -0000 Received: (qmail 1090 invoked by uid 22791); 2 Oct 2008 03:47:51 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Oct 2008 03:47:01 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw2.br.ibm.com (Postfix) with ESMTP id EC1F817F47F for ; Thu, 2 Oct 2008 00:30:58 -0300 (BRT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m923kp44868568 for ; Thu, 2 Oct 2008 00:46:51 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m923kwxW015734 for ; Thu, 2 Oct 2008 00:46:58 -0300 Received: from [9.8.11.203] ([9.8.11.203]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m923kwDg015726; Thu, 2 Oct 2008 00:46:58 -0300 Subject: Re: [PATCH 0/4] 'catch syscall' feature From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Michael Snyder Cc: "gdb-patches@sourceware.org" In-Reply-To: <48E40CF3.5090702@vmware.com> References: <1222798405.30389.22.camel@miki> <48E3FBE1.9030800@vmware.com> <1222902189.19318.8.camel@miki> <48E40CF3.5090702@vmware.com> Content-Type: text/plain; charset=iso-8859-1 Date: Thu, 02 Oct 2008 03:47:00 -0000 Message-Id: <1222919302.19318.18.camel@miki> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00042.txt.bz2 Hey Michael :-) On Wed, 2008-10-01 at 16:51 -0700, Michael Snyder wrote: > AFAIK, we're still using the CVS repository as the official source > repo. I don't use git. We also ask that patches be relative to > the current top-of-tree. Right. I've only used git because I feel more comfortable with it :-). And my patches are relative to the current top-of-tree, because the git repository is updated on every 1/2 hour :-). > However, I've done my best to massage your patch into the current > cvs tree. I'm attaching a CVS diff based on my best effort. Please > let me know if you can spot any mistakes. Thank you for this, but I think it won't be needed... Keep reading ;-P > I was able to build this, but it failed your test case > (thanks very much for including a test case, by the way). > I'm attaching my failing gdb.log. Well, maybe you have misunderstood things (or maybe I wasn't clear enough :-)). Currently, my patch only works for 32-bit PowerPC architecture, although I intend to implement the x86 support ASAP. > I want to thank you for the contribution while strongly > encouraging you to resubmit it relative to CVS HEAD. Well, going straight to the "business", I think I know what happened. My patch is inlined in the message, so it's not just a matter of "cut-and-paste" it. You must instead take the raw copy of the message (or messages, in this case), and apply the patches using them. To get the raw copy of the message, just download these URLs: http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798409.30389.23.camel%40miki http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798412.30389.24.camel%40miki http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798415.30389.26.camel%40miki http://sourceware.org/cgi-bin/get-raw-msg?listname=gdb-patches&date=2008-09&msgid=1222798416.30389.27.camel%40miki (Note that if you just open your browser and copy-and-paste the text won't work either... You must select "Save the page as...", or use a tool like wget to download the messages). After that, and if the stars are properly aligned, the patch should apply correctly :-). Please, let me know if you have other issues! Regards, -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil