From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1623 invoked by alias); 5 Sep 2008 03:38:33 -0000 Received: (qmail 1610 invoked by uid 22791); 5 Sep 2008 03:38:32 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Sep 2008 03:37:49 +0000 Received: from mailhub1.br.ibm.com (unknown [9.18.232.109]) by igw3.br.ibm.com (Postfix) with ESMTP id 311063900DC for ; Fri, 5 Sep 2008 00:16:45 -0300 (BRST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m853biZq2408510 for ; Fri, 5 Sep 2008 00:37:44 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m853bc7a013755 for ; Fri, 5 Sep 2008 00:37:38 -0300 Received: from [9.18.198.12] ([9.18.198.12]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m853ba4F013173; Fri, 5 Sep 2008 00:37:37 -0300 Subject: Re: [rfc] add ppc testcase to test fpscr From: Thiago Jung Bauermann To: Joel Brobecker Cc: gdb-patches ml In-Reply-To: <20080905001213.GB26618@adacore.com> References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain> <20080902215458.GB25623@caradoc.them.org> <1220472745.9671.13.camel@localhost.localdomain> <20080903210054.GA8670@caradoc.them.org> <1220491492.9671.17.camel@localhost.localdomain> <20080905001213.GB26618@adacore.com> Content-Type: text/plain; charset=utf-8 Date: Fri, 05 Sep 2008 03:38:00 -0000 Message-Id: <1220585825.19809.4.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00087.txt.bz2 El jue, 04-09-2008 a las 17:12 -0700, Joel Brobecker escribió: > > 2008-09-03 Thiago Jung Bauermann > > > > * gdb.arch/ppc-fp.exp: New file. > > * gdb.arch/ppc-fp.c: New file. > > This looks good to me. Just a question: > > On a couple of occasions, you use the "verbose" routine, and then > call it again with the same argument, except for the -log: > > > + verbose "Skipping powerpc floating point register tests." > > + verbose -log "Skipping powerpc floating point register tests." > > I searched throughout the gdb.base directory, and I found only uses > of verbose without -log. In testsuite/lib, I saw uses of both forms, > but never at the same time... No reason. I probably copied the wrong example. I can remove either of them, at will. :-) -- []'s Thiago Jung Bauermann IBM Linux Technology Center