From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58975 invoked by alias); 29 May 2018 15:58:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58964 invoked by uid 89); 29 May 2018 15:58:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 15:58:02 +0000 Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 51.7E.13413.8887D0B5; Tue, 29 May 2018 17:58:00 +0200 (CEST) Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSHC007.ericsson.se (153.88.183.39) with Microsoft SMTP Server (TLS) id 14.3.382.0; Tue, 29 May 2018 17:57:59 +0200 Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 29 May 2018 17:57:59 +0200 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Tue, 29 May 2018 17:57:59 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.60.133] (192.75.88.130) by BN7PR15MB2386.namprd15.prod.outlook.com (2603:10b6:406:8c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Tue, 29 May 2018 15:57:56 +0000 Subject: Re: [RFA] Change program_space::added_solibs to a std::vector To: Tom Tromey , References: <20180529151104.6387-1-tom@tromey.com> From: Simon Marchi Message-ID: <1218f244-a8b9-c184-2dc3-9ee22bb87451@ericsson.com> Date: Tue, 29 May 2018 16:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180529151104.6387-1-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0061.namprd05.prod.outlook.com (2603:10b6:803:41::38) To BN7PR15MB2386.namprd15.prod.outlook.com (2603:10b6:406:8c::24) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BN7PR15MB2386; X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2386;3:E9sD4m1bpb1JSJsAtf5uJ/pD4GJKAXYRQYrvaCfvmRS77uoh3lk6Z2uM16kWmqgg+TwoIz/pg9xuqjqcDnw29V2LaF78B0P34pv7Dlr2KBlX9m4F3nBFP4X5EAEcg0+Oqn14lE4bK6PYKAYzmNt6DuZxUduhfJgilCEZpZ7YV8argM3pdtplnyAJmve9fCsUOd+QZ+8fru9mRUwRMtDdZOjCt5JJq+oZfbem9sGVn6gDB7HrW9oWtZV0My8FB0VJ;25:qg+0iE+tvFzyRU4oYB7uzmcHg4QfIsusz61AZ8GRtRQAZjZ1B6MRvRKLL+302ST8EKQz2IlK35oeAZP0cvX+fmYeTlrM6Y+Q0XTZj1wC5dGIoqhI4vYckxKk8hxg1Q6jw5byxgAllU//yUAqkAWZrCg6tyYWaBce5OLhhvu0xxycsb2bzolnyj1T6aqtsqLNIwRk3xhTPDHbyWFfIkNcLEJjKNTgMcq+vkN1Vu9VFJM9N79Aw8RTy5YxbXbmJShNf8n6az73JzS7GMwT5SAMHgXKZgU1VEzMI6BBiULTVXrezawk7qTqYmCh3PANxhqsrdwrkJoyQVyAmg7RrvifSg==;31:RJ8Dccbr+io14QQXtsp6x84y/AfyBNZ0OoUTuYRVPnqLgjmu23mHgvyEMYfgAvIelVcO8gd9Fle7tQLo7oju2gG6fdljXcGKmmB6AptK6tuwfhHF+pEOJnFI0dJGfyTucoHRTsO7/IJlMsRTXjuq3llvrcQAe6CVvELDPSBDuGYlm7l8rAu654qtTbIvVbeZpE52dEjwwiN37C8uL1VRAP2g4CoIbIOkq+tCqEbSb6I= X-MS-TrafficTypeDiagnostic: BN7PR15MB2386: X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2386;20:nYTAn+cYlorB93cPFoJKWdX88lwC6wkdqT4k5O52fL0DVPASuKI1KkAZHg8eV/KUHd/SeK7YwiLVpYK6KMBXKeeYHZTx/3kMh+Pz8ZnbHbn7zQssybAX6y7WCdRLZVBDAs2lYwkllkkKDSgjX0tKvtr2DMuT7SONJs+M4KF33I5j2rcIeZn3QszHl4VCVaNDpczXhwWVk2hYpY5uMtVVDJCshBM8Yg+limc/8TjUZLphlhOPP7nhBc28/mQrMhz0rURgolbAe3iI9cFOtHIdtWmWSw3TIMBfUmpR8mUJtGIs8sANvvzNHoPpvRDkbdP8iUSjBcYCqSuA/g9IEtBHbJwwj76+bor64y2y65KBAUDNSW8LVLUVwnl9/H6DU+y133s+tQqbrNBGVkWC2hGiyGjVa2agzPH1tT/WbH8xOnjZsig6IaUh2nnkqx5GW+0A4OJyDNWCcNId3IQNaYdHjIY2F//Syvq+i12ikpkY58JXE+Sgd45376DAcMJbY21D;4:9hq7y8QNEcmhpEEClCDmSpANxSrWVWjtZX58iGfN5jJmSYQGlqq3fZRQdJpPm8QYNlwXVTPCcbfRcyoTwnuHXbH4ZujYvi7O4i0VjWwCg/tQ971+piibNcZ0TJN0l/GLMfXTz2fFQJvM/J19zv58LJ+vhXJu9V8oCpE73OninZ+Nn9rTOc5Hgdxfyftq2q2u2QQIlvR32UXhSwiSi9JQs1G+B1Pxu/OHncx03MBvBRBvIANPmkRApuY3x79m0P8NuqmiI2C7Wy6SFMc2l5/E1w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011)(7699016);SRVR:BN7PR15MB2386;BCL:0;PCL:0;RULEID:;SRVR:BN7PR15MB2386; X-Forefront-PRVS: 0687389FB0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(376002)(346002)(39380400002)(396003)(366004)(189003)(199004)(377424004)(54534003)(3846002)(105586002)(6116002)(8936002)(81156014)(6246003)(81166006)(106356001)(2486003)(316002)(8676002)(52146003)(478600001)(58126008)(16526019)(16576012)(23676004)(49976009)(36756003)(53546011)(305945005)(386003)(59450400001)(25786009)(7736002)(230700001)(52116002)(186003)(26005)(76176011)(53936002)(31686004)(65956001)(65826007)(229853002)(6666003)(486006)(6486002)(44832011)(64126003)(97736004)(47776003)(65806001)(5660300001)(66066001)(11346002)(50466002)(446003)(86362001)(68736007)(31696002)(476003)(956004)(2906002)(2616005)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR15MB2386;H:[142.133.60.133];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjE1TUIyMzg2OzIzOmlCTmdzaU1aKzZxYnQ3eGowbk1WdUlyQUlT?= =?utf-8?B?bnFKNUFRK3pZdzc2UlgwY21aVndXWXhYM1FmNFlyeEE5bE1vdlcrVmhXNnVw?= =?utf-8?B?ZEo1Tjhtb0ZpQnErMThMdDg3bDZZdGFJL2ZiN256T0E1ZjBtZnlhV0lCZzFV?= =?utf-8?B?Y0EwTUVDSktxTVdtQWMyaGk4d1hJNDZxQ0llU0Q4Z01US1p1ZjRhemxQK0hJ?= =?utf-8?B?TXlqR2hEd09SOTRBTEdrM3BSdWU3L1BxblljdE5kZU9tdTNXWWNUYTlVbER6?= =?utf-8?B?M2RGdlFXbmUyWHpnM2dCRWlQSTJUem9JVDlMNTFDSDRxYVg2UjVWcExIWkRt?= =?utf-8?B?L2JKZmtkZHMrVlAvc3ZEMTF0YlVjYzlhYjJUWXpGNmp3czcxeC9hRGpOT25D?= =?utf-8?B?V0F3bCtNckdrVlBaLzRyNVkweWYrSDFHUXJhOEhrZXB1N204Z012ckRrUTFW?= =?utf-8?B?cmJMVWswWFc4NlhsY3VNOUFOWXdMMFZONklaRTFTM2YzdGZNQ01mU3lJcGc1?= =?utf-8?B?K2dGdm5pVmVLNHhkUmxGcVovQmV0WmVzMUpTckd4U2hiNU1EQm5jRVVxTXJS?= =?utf-8?B?NzFUZG11UEdBRFNhN1pJWTRhZzRwd1hLVWI0ME9yR2ZtTEFielpVWE9NZXE0?= =?utf-8?B?UVdaN2F1TDUxM2txWDlLcW5idGFud090bGdNZXNRK25mQThpRlJwdThsVC92?= =?utf-8?B?YzFQT0RwamQxdlJPS1ZqRis2ZXNqYkptOVFFQm1Pb1lPMVkwV3BRdEx2UXU0?= =?utf-8?B?L0VLYXo0anNlWG4xcm1MbHNDdU1DZ2dCeDlodmo4RGZFWmljYWhKenFMb0Nn?= =?utf-8?B?TnQvYmY2WWp1Q0FydE1XL0hycnF0Qmo0WFphMk13MWp6SEZvMXZvRTBGY2tF?= =?utf-8?B?dnlyWTFQZWZoTkF1azFzRW5wSlJVdTF0a0NlMTNIUk5zazJvRVpMYjdyVWZo?= =?utf-8?B?MEN0MGpJdjdXeHlvcjd1eElnU2FMdHRCdWJuV0ZINGk0QmNNMWpsT1liaFZF?= =?utf-8?B?bkh2a25nQ0V6NzVXWXNQUmRtbnVlb25wa2RsUW1tNVB0bW9MeVhjVXoxT0Vo?= =?utf-8?B?ODlHMGZnNVdlK21WanNTZkdmMmMyVXc3V3V1cTY3cmZTeGIwMVB6Y2J5ODMw?= =?utf-8?B?dHVIejhnM3cwc1Y1Zlg5THBneW9ibGUrM0RNOFliWkhhYXlnSUI0Qk8yZXZm?= =?utf-8?B?eGIwakZMS3hUS0l0VXNOTldEQk5VYzYzL255SncwTGFMb1J5VEpLcmhLQmZx?= =?utf-8?B?SWJGaXJBemhqQjVuUGs2VlE3NkdsRk1wL1UreFFhN3I3eUZCU1hyQTBpMkZn?= =?utf-8?B?N2xMT2h5ODVGS25QZ29zZElHK1NwTnpuVVpYNWZVYTNXYXJuNWxRMnczcmxO?= =?utf-8?B?U085WlZ0ZENxYWhoVGhQcVJOVmFzb2dJaGJBbnFFWVN6RmlYTG5aWkxNeGkr?= =?utf-8?B?dy82dDVueXhXY2swcEdGS3VJSGt2a0k1M0RXY0toNXZWK2x6b01sREE0ZkhF?= =?utf-8?B?WElqZ0NveHVNd2tkWEl5eVB1RmVXWVkzZHIwZDcvelFPbVRKZWh4ZVNvUzUr?= =?utf-8?B?ZjRBaWNMVmtscU53bVg0VWdxSVVzYW9UbnRUSFcvNklnNTljZjZyMVBKTnRr?= =?utf-8?B?MHZYVllPdkR1VFo0dmdRb3NVdjRsSjQzZFZ2TWVGMXNwTk1oVC9hdTR0azh4?= =?utf-8?B?bkt4TjNzVW90bkp0U2l5cTVHdGUzYW1ieFpDa29wd3pkbyttQWR4M0dPUndr?= =?utf-8?B?UFlLblYxMzZSUjdEUSt1dng4dVhSdW5GNGhGSUpmME1ycFphcHJZWDdBMXJR?= =?utf-8?B?R1ovd05NQVZCcmdqKzE0UWhxWWJuRUYyU0tmeitRRC9qNTBvWndzeGhzc2t5?= =?utf-8?B?NzJtR0NQQTlnVFhjMUdPZzFYYUJ1OEd1Zm9aeDl3d0YyMFNPbjZBV2MvSGdZ?= =?utf-8?B?ZGdnQTdmN3NHZFRhdWRsaStvbm5KZHR1SVdQZ1dOVnBxeVZ5Z25aL3BaK1RP?= =?utf-8?B?aWJWa0JUQ1VXSnc3bkUyWDI1VVA1SHJ0SnBWdz09?= X-Microsoft-Antispam-Message-Info: 1No9B/KS2Fu6i1p0TOyMTfivp2pVA2wZBNrUTLH3zc5iiGSLk8jriB2uJ0qcgGtJkmoEHF2dOFzTYIN9wHoBNC1vnDp3U1rQs0kkjGF0rAXhCdAEhzqQxP2mStvUNYXOVsBJJeCRfXSnnkw0961TY4W0jsCm/TpkJUCWSakxq0SHosao+PVbSU9TbiYOm1o+ X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2386;6:0ckaCA3rzslq6r61N30YWOT6uIzWLLK4an4ZrFoAW/QoubZq36Oo/AomheGV+EcNGDdjaDcCSKlQ+R5ipti4e0ntlRvDHlpqY0FhtWR7eVL7wPn7hp8K+2cqBuFcDoYD/4JjA2fEYn06Mw8wSEkbswHp2VgKq5ZGCZ7w2gBe4ivTasFdbanvKg7HKG8tU+/DZevrgSYApP5nty6FN2tt8N9zmGMIkZC7Efb/QlWOtF5KHdwAAky+k21ZtZ5hVqw/ZKloQdZJj+fv7pNrbTPBUg6VkmHqtYokU79o+Fcb3rMQARv5DTWzCrvf3IrVOU8D9s2xzVsBxb+0rdNPObbmuloSMYJljnJ1F7vMSO/otElj5PyiCChrrU9L4MqHazdzlS1TLiEFY014k7SPwmQVH4nYDaGOtSPDyE/ZJeS5+vZB2qAcx5JqSZSz9v7zDNbP4LSjeH62EIbwXVvuB1NYOA==;5:CheiIgYdNnT+u47ZXhJIN3waW/9GZbBl0pEbFCqyb+GITIbE7mLxaGkFeyfwN0I+NfQRzUc1vLujjYaj/QQ6xNTi6qy8SKAUs9YpV6++3sSnrer8u/YEMFkxCJow5tpLkwH9RzTg0KekYUVFMHHjQ5cx6rQjgYuUIP4ADjw8rbY=;24:bdr9yITnDnZq3OjdENEZ2WnC6XZNaU84YMXe9iKoeT6pm0DklfccxDgA4L7clqizBTsv6JrKQCATciFva1191buuXendgzIHn9lEWRvwwYY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2386;7:Ko6v1UfkMc7mgsfw41J1c6XEpspMVHTAIC1VWBiH2HJWZMRmQNM/mB2oYpkbZpSqGHYTWgQc5AY9zbz3Hlbu9gfRLTY8JZ7ixNFwknnmzgmMqzwUGL3khXm62FgvXZsBQh3aPRDMRB74CgW4oNHAPdEM4OTkVrpq6UnRjHKPdXV39kKNnYZYeywH+8FLrWm1m3390HvhVCP9FVOrUMTBAaucbztH6fjw+yVMNkjko7htfY2PNHdrqjQpO4vXjqzp X-MS-Office365-Filtering-Correlation-Id: 50a5c5fe-e00f-4c45-6098-08d5c57cf1fc X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2018 15:57:56.3477 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50a5c5fe-e00f-4c45-6098-08d5c57cf1fc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2386 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00768.txt.bz2 On 2018-05-29 11:11 AM, Tom Tromey wrote: > This changes program_space::added_solibs to a std::vector, removing a > VEC. > > Tested by the buildbot. > > ChangeLog > 2018-05-29 Tom Tromey > > * progspace.h (so_list_ptr): Remove typedef. Don't declare VEC. > (struct program_space) : Now a std::vector. > * breakpoint.c (print_solib_event): Update. > (check_status_catch_solib): Update. > * progspace.c (clear_program_space_solib_cache): Update. > * solib.c (update_solib_list): Update. > --- > gdb/ChangeLog | 9 +++++++++ > gdb/breakpoint.c | 22 ++++++---------------- > gdb/progspace.c | 3 +-- > gdb/progspace.h | 5 +---- > gdb/solib.c | 2 +- > 5 files changed, 18 insertions(+), 23 deletions(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 721afd2c049..291442a6b55 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -4580,8 +4580,7 @@ static void > print_solib_event (int is_catchpoint) > { > bool any_deleted = !current_program_space->deleted_solibs.empty (); > - int any_added > - = !VEC_empty (so_list_ptr, current_program_space->added_solibs); > + int any_added = !current_program_space->added_solibs.empty (); bool? Otherwise LGTM. Thanks, Simon