From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com, drow@false.org
Subject: Re: Fix python indented multi-line commands
Date: Thu, 14 Aug 2008 19:42:00 -0000 [thread overview]
Message-ID: <1218742708.554.0.camel@localhost.localdomain> (raw)
In-Reply-To: <ur68rflok.fsf@gnu.org>
On Thu, 2008-08-14 at 22:20 +0300, Eli Zaretskii wrote:
> > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > Cc: gdb-patches@sources.redhat.com, Daniel Jacobowitz <drow@false.org>
> > Date: Thu, 14 Aug 2008 00:55:23 -0300
> >
> > > Please don't call variables by mysterious names such as
> > > "special_processing". Please give that variable a meaningful name
> > > that would explain the purpose of this flag even without reading the
> > > code of the callers of this function.
> >
> > I agree. The argument has two effects though (stripping of leading
> > whitespace, and recognizing GDB control commands), so I had some
> > difficulty in finding a meaningful name for it. That's why I left it
> > with that one. It is now called parse_input, what do you think?
>
> "parse_commands"? Or maybe "only_end_cmd" (and reverse the tests)?
parse_commands is good. Do we have a deal? :-)
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2008-08-14 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 6:41 Thiago Jung Bauermann
2008-08-13 12:41 ` Daniel Jacobowitz
2008-08-13 18:22 ` Eli Zaretskii
2008-08-14 3:57 ` Thiago Jung Bauermann
2008-08-14 19:21 ` Eli Zaretskii
2008-08-14 19:42 ` Thiago Jung Bauermann [this message]
2008-08-15 4:13 ` Daniel Jacobowitz
2008-08-16 20:40 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218742708.554.0.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox