From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27328 invoked by alias); 2 Aug 2008 03:27:08 -0000 Received: (qmail 27319 invoked by uid 22791); 2 Aug 2008 03:27:07 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 02 Aug 2008 03:26:35 +0000 Received: from mailhub1.br.ibm.com (unknown [9.18.232.109]) by igw3.br.ibm.com (Postfix) with ESMTP id 9928F39008B for ; Sat, 2 Aug 2008 00:07:30 -0300 (BRST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m723QWQ02277618 for ; Sat, 2 Aug 2008 00:26:37 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m723QQQN016633 for ; Sat, 2 Aug 2008 00:26:27 -0300 Received: from [9.18.196.162] ([9.18.196.162]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m723QQRm016630; Sat, 2 Aug 2008 00:26:26 -0300 Subject: Re: [PATCH-ppc 0/5] Add feature description for new VSX register set From: Thiago Jung Bauermann To: luisgpm@linux.vnet.ibm.com Cc: gdb-patches@sourceware.org In-Reply-To: <1217016935.29012.74.camel@gargoyle> References: <1217016935.29012.74.camel@gargoyle> Content-Type: text/plain Date: Sat, 02 Aug 2008 03:27:00 -0000 Message-Id: <1217647586.26214.11.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00023.txt.bz2 On Fri, 2008-07-25 at 17:15 -0300, Luis Machado wrote: > This specific patch adds 32 new 64-bit wide "vsxh" (doubleword 1 of > VSR0~VSR31) registers and addresses the required dependencies in the > makefiles. Reviewed and found only very minor things. > * features/res6000/powerpc-vsx32.c: New file (generated). > * features/res6000/powerpc-vsx32l.c: New file (generated). > * features/res6000/powerpc-vsx64.c: New file (generated). > * features/res6000/powerpc-vsx64l.c: New file (generated). > * features/Makefile: Updated with new descriptions. > * regformats/rs6000/powerpc-vsx32l.dat: New file (generated). > * regformats/rs6000/powerpc-vsx64l.dat: New file (generated). Please don't include generated files in the patch. It just adds noise and makes the review more difficult. > * Makefile: Updated with new descriptions. It's Makefile.in, actually. > Index: gdb/features/rs6000/powerpc-vsx32l.xml > =================================================================== > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ gdb/features/rs6000/powerpc-vsx32l.xml 2008-07-25 08:24:19.000000000 -0700 > @@ -0,0 +1,20 @@ > + > + > + > + ... and VSX vector registers. > Index: gdb/features/rs6000/powerpc-vsx64.xml > =================================================================== > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ gdb/features/rs6000/powerpc-vsx64.xml 2008-07-25 08:24:19.000000000 -0700 > @@ -0,0 +1,18 @@ > + > + > + > + ditto > Index: gdb/features/rs6000/powerpc-vsx64l.xml > =================================================================== > --- /dev/null 1970-01-01 00:00:00.000000000 +0000 > +++ gdb/features/rs6000/powerpc-vsx64l.xml 2008-07-25 08:24:19.000000000 -0700 > @@ -0,0 +1,20 @@ > + > + > + > + Same here. -- []'s Thiago Jung Bauermann IBM Linux Technology Center