Re: [PATCH-ppc 4/5] Add VSX registers testcase

Luis Machado
2008-08-08T15:19:17Z

Ping?

On Fri, 2008-07-25 at 18:43 -0300, Luis Machado wrote:
> Fixed small gotchas in this patch. Also, it's worth noticing that i've
> re-used the vmx testcase C source file since it's closely related to the
> VSX behavior.
>
> Luis
>
> On Fri, 2008-07-25 at 17:15 -0300, Luis Machado wrote:
> > This one adds a small testcase to check if the VSX registers are being
> > correctly read from/written. It also tests core-file support by
> > writting
> > and reading VSX registers back.
> >
> > There is also a small additional to lib/gdb.exp to check if both the
> > compiler and machine has VSX support.
>
> ---
> 2008-07-25 Luis Machado <luisgpm@br.ibm.com>
>
> * gdb.arch/vsx-regs.c: New source file.
> * gdb.arch/vsx-regs.exp: New testcase.
> * lib/gdb.exp (skip_vsx_tests): New function.
>
> Index: gdb/testsuite/gdb.arch/vsx-regs.c
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ gdb/testsuite/gdb.arch/vsx-regs.c 2008-07-25 09:54:03.000000000 -0700
> @@ -0,0 +1,41 @@
> +#include <altivec.h>
> +#include <stdio.h>
> +
> +vector unsigned int
> +vector_fun (vector unsigned int a, vector unsigned int b)
> +{
> + vector unsigned int c;
> + a = ((vector unsigned int) vec_splat_u8(2));
> + b = ((vector unsigned int) vec_splat_u8(3));
> +
> + c = vec_add (a, b);
> + return c;
> +}
> +
> +int
> +main ()
> +{
> + vector unsigned int y;
> + vector unsigned int x;
> + vector unsigned int z;
> + int a;
> +
> + /* This line may look unnecessary but we do need it, because we want to
> + have a line to do a next over (so that gdb refetches the registers)
> + and we don't want the code to change any vector registers.
> + The splat operations below modify the VRs,i
> + so we don't want to execute them yet. */
> + a = 9;
> + x = ((vector unsigned int) vec_splat_u8 (-2));
> + y = ((vector unsigned int) vec_splat_u8 (1));
> +
> + z = vector_fun (x, y);
> + x = vec_sld (x,y,2);
> +
> + x = vec_add (x, ((vector unsigned int){5,6,7,8}));
> + z = (vector unsigned int) vec_splat_u8 ( -2);
> + y = vec_add (x, z);
> + z = (vector unsigned int) vec_cmpeq (x,y);
> +
> + return 0;
> +}
> Index: gdb/testsuite/gdb.arch/vsx-regs.exp
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ gdb/testsuite/gdb.arch/vsx-regs.exp 2008-07-25 09:54:03.000000000 -0700
> @@ -0,0 +1,193 @@
> +# Copyright (C) 2008 Free Software Foundation, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +# Please email any bugs, comments, and/or additions to this file to:
> +# bug-gdb@prep.ai.mit.edu
> +#
> +
> +# Tests for Powerpc AltiVec register setting and fetching
> +
> +if $tracelevel then {
> + strace $tracelevel
> +}
> +
> +#
> +# Test the use of VSX registers, for Powerpc.
> +#
> +
> +set prms_id 0
> +set bug_id 0
> +
> +if {![istarget "powerpc*"] || [skip_vsx_tests]} then {
> + verbose "Skipping vsx register tests."
> + verbose -log "Skipping vsx register tests."
> + return
> +}
> +
> +set testfile "vsx-regs"
> +set binfile ${objdir}/${subdir}/${testfile}
> +set srcfile ${testfile}.c
> +
> +set compile_flags {debug nowarnings quiet}
> +if [get_compiler_info $binfile] {
> + warning "get_compiler failed"
> + return -1
> +}
> +
> +if [test_compiler_info gcc*] {
> + set compile_flags "$compile_flags additional_flags=-maltivec additional_flags=-mabi=altivec"
> +} elseif [test_compiler_info xlc*] {
> + set compile_flags "$compile_flags additional_flags=-qaltivec"
> +} else {
> + warning "unknown compiler"
> + return -1
> +}
> +
> +if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable $compile_flags] != "" } {
> + untested vsx-regs.exp
> + return -1
> +}
> +
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
> +
> +# Run to `main' where we begin our tests.
> +
> +if ![runto_main] then {
> + gdb_suppress_tests
> +}
> +
> +# Data sets used throughout the test
> +
> +set vector_register1 ".uint128 = 0x3ff4cccccccccccc0000000000000000, v4_float = .0x1, 0xf99999a0, 0x0, 0x0., v4_int32 = .0x3ff4cccc, 0xcccccccc, 0x0, 0x0., v8_int16 = .0x3ff4, 0xcccc, 0xcccc, 0xcccc, 0x0, 0x0, 0x0, 0x0., v16_int8 = .0x3f, 0xf4, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0.."
> +
> +set vector_register2 "uint128 = 0xdeadbeefdeadbeefdeadbeefdeadbeef, v4_float = .0x0, 0x0, 0x0, 0x0., v4_int32 = .0xdeadbeef, 0xdeadbeef, 0xdeadbeef, 0xdeadbeef., v8_int16 = .0xdead, 0xbeef, 0xdead, 0xbeef, 0xdead, 0xbeef, 0xdead, 0xbeef., v16_int8 = .0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef.."
> +
> +set vector_register3 ".uint128 = 0x00000001000000010000000100000001, v4_float = .0x0, 0x0, 0x0, 0x0., v4_int32 = .0x1, 0x1, 0x1, 0x1., v8_int16 = .0x0, 0x1, 0x0, 0x1, 0x0, 0x1, 0x0, 0x1., v16_int8 = .0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x1.."
> +
> +set float_register ".raw 0xdeadbeefdeadbeef."
> +
> +# First run the F0~F31/VS0~VS31 tests
> +
> +# 1: Set F0~F31 registers and check if it reflects on VS0~VS31.
> +for {set i 0} {$i < 32} {incr i 1} {
> + send_gdb "set \$f$i = 1\.3"
> +}
> +
> +for {set i 0} {$i < 32} {incr i 1} {
> + gdb_test "info reg vs$i" "vs$i.*$vector_register1" "info reg vs$i (doubleword 0)"
> +}
> +
> +# 2: Set VS0~VS31 registers and check if it reflects on F0~F31.
> +for {set i 0} {$i < 32} {incr i 1} {
> + for {set j 0} {$j < 4} {incr j 1} {
> + send_gdb "set \$vs$i.v4_int32\[$j\] = 0xdeadbeef"
> + }
> +}
> +
> +for {set i 0} {$i < 32} {incr i 1} {
> + gdb_test "info reg f$i" "f$i.*$float_register" "info reg f$i"
> +}
> +
> +for {set i 0} {$i < 32} {incr i 1} {
> + gdb_test "info reg vs$i" "vs$i.*$vector_register2" "info reg vs$i (doubleword 1)"
> +}
> +
> +# Now run the VR0~VR31/VS32~VS63 tests
> +
> +# 1: Set VR0~VR31 registers and check if it reflects on VS32~VS63.
> +for {set i 0} {$i < 32} {incr i 1} {
> + for {set j 0} {$j < 4} {incr j 1} {
> + send_gdb "set \$vr$i.v4_int32\[$j\] = 1"
> + }
> +}
> +
> +for {set i 32} {$i < 64} {incr i 1} {
> + gdb_test "info reg vs$i" "vs$i.*$vector_register3" "info reg vs$i"
> +}
> +# 2: Set VS32~VS63 registers and check if it reflects on VR0~VR31.
> +for {set i 32} {$i < 64} {incr i 1} {
> + for {set j 0} {$j < 4} {incr j 1} {
> + send_gdb "set \$vs$i.v4_int32\[$j\] = 1"
> + }
> +}
> +
> +for {set i 0} {$i < 32} {incr i 1} {
> + gdb_test "info reg vr$i" "vr$i.*$vector_register3" "info reg vr$i"
> +}
> +
> +set escapedfilename [string_to_regexp ${objdir}/${subdir}/vsx-core.test]
> +
> +set core_supported 0
> +
> +gdb_test_multiple "gcore ${objdir}/${subdir}/vsx-core.test" \
> + "Save a VSX-enabled corefile" \
> +{
> + -re "Saved corefile ${escapedfilename}\[\r\n\]+$gdb_prompt $" {
> + pass "Save a VSX-enabled corefile"
> + global core_supported
> + set core_supported 1
> + }
> + -re "Can't create a corefile\[\r\n\]+$gdb_prompt $" {
> + unsupported "Save a VSX-enabled corefile"
> + global core_supported
> + set core_supported 0
> + }
> +}
> +
> +if {!$core_supported} {
> + return -1
> +}
> +
> +gdb_exit
> +gdb_start
> +gdb_reinitialize_dir $srcdir/$subdir
> +gdb_load ${binfile}
> +
> +gdb_test_multiple "core ${objdir}/${subdir}/vsx-core.test" \
> + "re-load generated corefile" \
> +{
> + -re ".* is not a core dump:.*$gdb_prompt $" {
> + fail "re-load generated corefile (bad file format)"
> + # No use proceeding from here.
> + return;
> + }
> + -re ".*: No such file or directory.*$gdb_prompt $" {
> + fail "re-load generated corefile (file not found)"
> + # No use proceeding from here.
> + return;
> + }
> + -re ".*Couldn't find .* registers in core file.*$gdb_prompt $" {
> + fail "re-load generated corefile (incomplete note section)"
> + }
> + -re "Core was generated by .*$gdb_prompt $" {
> + pass "re-load generated corefile"
> + }
> + -re ".*$gdb_prompt $" {
> + fail "re-load generated corefile"
> + }
> + timeout {
> + fail "re-load generated corefile (timeout)"
> + }
> +}
> +
> +for {set i 0} {$i < 32} {incr i 1} {
> + gdb_test "info reg vs$i" "vs$i.*$vector_register2" "Restore vs$i from core file"
> +}
> +
> +for {set i 32} {$i < 64} {incr i 1} {
> + gdb_test "info reg vs$i" "vs$i.*$vector_register3" "Restore vs$i from core file"
> +}
> Index: gdb/testsuite/lib/gdb.exp
> ===================================================================
> --- gdb.orig/testsuite/lib/gdb.exp 2008-07-25 09:53:41.000000000 -0700
> +++ gdb/testsuite/lib/gdb.exp 2008-07-25 14:39:32.000000000 -0700
> @@ -1349,6 +1349,92 @@
> return $skip_vmx_tests_saved
> }
>
> +# Run a test on the target to see if it supports vmx hardware. Return 0 if so,
> +# 1 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite.
> +
> +proc skip_vsx_tests {} {
> + global skip_vsx_tests_saved
> + global srcdir subdir gdb_prompt
> +
> + # Use the cached value, if it exists.
> + set me "skip_vsx_tests"
> + if [info exists skip_vsx_tests_saved] {
> + verbose "$me: returning saved $skip_vsx_tests_saved" 2
> + return $skip_vsx_tests_saved
> + }
> +
> + # Some simulators are known to not support Altivec instructions, so
> + # they won't support VSX instructions as well.
> + if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] } {
> + verbose "$me: target known to not support VSX, returning 1" 2
> + return [set skip_vsx_tests_saved 1]
> + }
> +
> + # Make sure we have a compiler that understands altivec.
> + set compile_flags {debug nowarnings quiet}
> + if [get_compiler_info not-used] {
> + warning "Could not get compiler info"
> + return 1
> + }
> + if [test_compiler_info gcc*] {
> + set compile_flags "$compile_flags additional_flags=-mvsx"
> + } elseif [test_compiler_info xlc*] {
> + set compile_flags "$compile_flags additional_flags=-qvsx"
> + } else {
> + verbose "Could not compile with vsx support, returning 1" 2
> + return 1
> + }
> +
> + set src vsx[pid].c
> + set exe vsx[pid].x
> +
> + set f [open $src "w"]
> + puts $f "int main() {"
> + puts $f "#ifdef __MACH__"
> + puts $f " asm volatile (\"lxvd2x v0,v0,v0\");"
> + puts $f "#else"
> + puts $f " asm volatile (\"lxvd2x 0,0,0\");"
> + puts $f "#endif"
> + puts $f " return 0; }"
> + close $f
> +
> + verbose "$me: compiling testfile $src" 2
> + set lines [gdb_compile $src $exe executable $compile_flags]
> + file delete $src
> +
> + if ![string match "" $lines] then {
> + verbose "$me: testfile compilation failed, returning 1" 2
> + return [set skip_vsx_tests_saved 1]
> + }
> +
> + # No error message, compilation succeeded so now run it via gdb.
> +
> + gdb_exit
> + gdb_start
> + gdb_reinitialize_dir $srcdir/$subdir
> + gdb_load "$exe"
> + gdb_run_cmd
> + gdb_expect {
> + -re ".*Illegal instruction.*${gdb_prompt} $" {
> + verbose -log "\n$me VSX hardware not detected"
> + set skip_vsx_tests_saved 1
> + }
> + -re ".*Program exited normally.*${gdb_prompt} $" {
> + verbose -log "\n$me: VSX hardware detected"
> + set skip_vsx_tests_saved 0
> + }
> + default {
> + warning "\n$me: default case taken"
> + set skip_vsx_tests_saved 1
> + }
> + }
> + gdb_exit
> + remote_file build delete $exe
> +
> + verbose "$me: returning $skip_vsx_tests_saved" 2
> + return $skip_vsx_tests_saved
> +}
> +
> # Skip all the tests in the file if you are not on an hppa running
> # hpux target.
>
>
>