From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57396-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6632 invoked by alias); 23 Jul 2008 03:49:01 -0000
Received: (qmail 6624 invoked by uid 22791); 23 Jul 2008 03:49:00 -0000
X-Spam-Check-By: sourceware.org
Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Jul 2008 03:48:32 +0000
Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) 	by bluesmobile.specifix.com (Postfix) with ESMTP id BE5153C25F; 	Tue, 22 Jul 2008 20:48:30 -0700 (PDT)
Subject: Re: [PATCH][gdbserver] Check for sys/dir.h and sys.user.h in 	configuration.
From: Michael Snyder <msnyder@specifix.com>
To: Doug Kwan =?UTF-8?Q?=28=E9=97=9C=E6=8C=AF=E5=BE=B7=29?= <dougkwan@google.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com>
References: <498552560807221759w1ade0ec2jd63c12475ddb5217@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Date: Wed, 23 Jul 2008 03:49:00 -0000
Message-Id: <1216784910.3549.496.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7)
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-07/txt/msg00408.txt.bz2

On Tue, 2008-07-22 at 17:59 -0700, Doug Kwan (關振德) wrote:
> Hi,
> 
>     gdbserver does not compile for the Android operating system
> because of missing headers sys/user.h and sys/dir.h and a declaration
> of errno inside a function.  The following patch fixes these problem.
> Does it look okay? If so, could someone approve and commit it for me?
> Thanks.
> 
> -Doug
> 
> 2008-07-22  Doug Kwan  <dougkwan@google.com>
> 
>         * configure.ac: Check for sys/dir.h and sys.user.h.
>         * config.in configure: Regenerate.
>         * linux-low.c: Include <sys/dir.h> if HAVE_SYS_DIR_H is defined.
>         Include <sys/user.h> if HAVE_SYS_USER_H is defined.
>         (linux_write_memory): Declare errno if STDC_HEADERS is not defined.

I'm surprised by some of the diffs in the generated configure
script -- wonder if you used a different version of autoconf
or something?

Otherwise looks pretty OK.  
I don't know enough to say whether STDC_HEADERS is the right
ifdef for the errno change in linux_write_memory.