From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2965 invoked by alias); 21 Jul 2008 16:47:56 -0000 Received: (qmail 2953 invoked by uid 22791); 21 Jul 2008 16:47:55 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 Jul 2008 16:47:29 +0000 Received: from mailhub1.br.ibm.com (unknown [9.18.232.109]) by igw3.br.ibm.com (Postfix) with ESMTP id 211EB390142 for ; Mon, 21 Jul 2008 13:28:50 -0300 (BRST) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m6LFuDrc2064568 for ; Mon, 21 Jul 2008 13:47:17 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m6LFiKrM002364 for ; Mon, 21 Jul 2008 12:44:20 -0300 Received: from [9.18.198.195] ([9.18.198.195]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m6LFiJpk002359; Mon, 21 Jul 2008 12:44:19 -0300 Subject: Re: [RFA][patch 1/9] Yet another respin of the patch with initial Python support From: Thiago Jung Bauermann To: Daniel Jacobowitz Cc: Tom Tromey , gdb-patches ml , Eli Zaretskii In-Reply-To: <1216653969.31797.6.camel@localhost.localdomain> References: <20080429155212.444237503@br.ibm.com> <20080429155304.288626880@br.ibm.com> <20080528205921.GA2969@caradoc.them.org> <20080615181833.uxmo25mg0kko40kw@imap.linux.ibm.com> <1216107418.14956.27.camel@localhost.localdomain> <1216245620.12209.18.camel@localhost.localdomain> <20080718195010.GA14356@caradoc.them.org> <1216653969.31797.6.camel@localhost.localdomain> Content-Type: text/plain Date: Mon, 21 Jul 2008 16:47:00 -0000 Message-Id: <1216655059.31797.9.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00393.txt.bz2 On Mon, 2008-07-21 at 12:26 -0300, Thiago Jung Bauermann wrote: > @@ -1283,7 +1303,11 @@ test-cp-name-parser$(EXEEXT): test-cp-na > # duplicates. Files in the gdb/ directory can end up appearing in > # COMMON_OBS (as a .o file) and CONFIG_SRCS (as a .c file). > > -INIT_FILES = $(COMMON_OBS) $(TSOBS) $(CONFIG_SRCS) > +# NOTE: bauermann/2008-06-15: python.c needs to be explicitly included > +# because the generation of init.c does not work for .c files which > +# result in differently named objects (i.e., python/python -> python.o). > + > +INIT_FILES = $(COMMON_OBS) $(TSOBS) $(CONFIG_SRCS) python/python.c > init.c: $(INIT_FILES) > @echo Making init.c > @rm -f init.c-tmp init.l-tmp Please ignore this hunk, it shouldn't be there and won't be committed (*sigh*). The rest of the patch is ok. Thanks, Tromey, for sanity checking this post and spotting this. -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center