From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30279 invoked by alias); 19 May 2008 13:27:54 -0000 Received: (qmail 30271 invoked by uid 22791); 19 May 2008 13:27:54 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 19 May 2008 13:27:32 +0000 Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) by igw1.br.ibm.com (Postfix) with ESMTP id E8E0532C138 for ; Mon, 19 May 2008 10:03:11 -0300 (BRST) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4JDR70K725058 for ; Mon, 19 May 2008 10:27:08 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4JDR4Nx006965 for ; Mon, 19 May 2008 10:27:04 -0300 Received: from [9.18.196.30] ([9.18.196.30]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m4JDR3vg006937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 May 2008 10:27:03 -0300 Subject: Re: [PATCH] PPC - Stepping off breakpoints in non-stop mode From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Pedro Alves Cc: gdb-patches@sourceware.org In-Reply-To: <200805191422.49117.pedro@codesourcery.com> References: <1209753019.7131.29.camel@gargoyle> <200805191422.49117.pedro@codesourcery.com> Content-Type: text/plain Date: Mon, 19 May 2008 15:21:00 -0000 Message-Id: <1211203623.6232.2.camel@gargoyle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00554.txt.bz2 On Mon, 2008-05-19 at 14:22 +0100, Pedro Alves wrote: > A Friday 02 May 2008 19:30:18, Luis Machado wrote: > > +void > +ppc_displaced_step_fixup (struct gdbarch *gdbarch, > + struct displaced_step_closure *closure, > + CORE_ADDR from, CORE_ADDR to, > + struct regcache *regs) > +{ > + /* Since we use simple_displaced_step_copy_insn, our closure is a > + copy of the instruction. */ > + unsigned int *insn = (unsigned int *) closure; > + unsigned int opcode = (*insn & BRANCH_MASK); > > ... > + char link_register_bit = (char) (*insn & 0x1); > + unsigned long current_pc; > > Using unsigned int, char and unsigned long in a tdep file isn't > safe. Can you switch to gdb_bytes and CORE_ADDR's? This file > is used for cross-debugging. Yes, that's true. I'll get this fixed. Thanks! Regards, Luis